Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) os,vm: fix segfaults and CHECK failure #13871

Closed
wants to merge 1 commit into from
Closed

(v6.x backport) os,vm: fix segfaults and CHECK failure #13871

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jun 22, 2017 •
edited
Loading

Original commit message:

Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
PR-URL: #12371
Reviewed-By: Anna Henningsen [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

os, vm

@tniessen
os,vm: fix segfaults and CHECK failure
408d69b 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: nodejs#12369
Fixes: nodejs#12370
PR-URL: nodejs#12371
Reviewed-By: Anna Henningsen <[email protected]>
@tniessen tniessen added os Issues and PRs related to the os subsystem. vm Issues and PRs related to the vm subsystem. labels Jun 22, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. v6.x vm Issues and PRs related to the vm subsystem. labels Jun 22, 2017
@tniessen tniessen mentioned this pull request Jun 22, 2017
Closed
3 tasks
@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8798/

@gibfahn gibfahn self-assigned this Jun 22, 2017
@tniessen
Copy link
Member Author

CI failures appear to be unrelated, can someone confirm this?

@bnoordhuis
Copy link
Member

Yes, unrelated.

@nxhack nxhack mentioned this pull request Jul 9, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Jul 10, 2017
@tniessen @MylesBorins
os,vm: fix segfaults and CHECK failure
c29063d 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
Backport-PR-URL: #13871
PR-URL: #12371
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

landed in c29063d

MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@tniessen @MylesBorins
os,vm: fix segfaults and CHECK failure
47e7020 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
Backport-PR-URL: #13871
PR-URL: #12371
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

@gibfahn gibfahn

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @bnoordhuis @MylesBorins @jasnell @gibfahn @nodejs-github-bot