Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use mustNotCall in test-http-eof-on-connect #13587

Closed
wants to merge 1 commit into from
Closed

test: use mustNotCall in test-http-eof-on-connect #13587

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 9, 2017

Confirm that callback is not being invoked in
test-http-eof-on-connect.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

@Trott
test: use mustNotCall in test-http-eof-on-connect
6c00afe 
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Jun 9, 2017
@Trott
Copy link
Member Author

Trott commented Jun 11, 2017

CI is in bad shape right now, but hope springs eternal...

CI: https://ci.nodejs.org/job/node-test-pull-request/8601/

Trott added a commit to Trott/io.js that referenced this pull request Jun 12, 2017
@Trott
test: use mustNotCall in test-http-eof-on-connect
77d575d 
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.

PR-URL: nodejs#13587
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 12, 2017

Landed in 77d575d

@Trott Trott closed this Jun 12, 2017
addaleax pushed a commit that referenced this pull request Jun 17, 2017
@Trott @addaleax
test: use mustNotCall in test-http-eof-on-connect
3f407ec 
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.

PR-URL: #13587
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 17, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@Trott @addaleax
test: use mustNotCall in test-http-eof-on-connect
5cb3fac 
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.

PR-URL: #13587
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@Trott @MylesBorins
test: use mustNotCall in test-http-eof-on-connect
245f6b0 
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.

PR-URL: #13587
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: use mustNotCall in test-http-eof-on-connect
406b3c0 
Confirm that callback is not being invoked in
test-http-eof-on-connect.js.

PR-URL: #13587
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the to-call-or-not-to-call branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @refack @jasnell @addaleax @lpinca @cjihrig @gibfahn @MylesBorins