Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: exec's promisify impl now includes stdout/err in error #13388

Closed
wants to merge 4 commits into from
Closed

child_process: exec's promisify impl now includes stdout/err in error #13388

wants to merge 4 commits into from

Commits on Jun 2, 2017

  1. child_process: exec's promisify impl now includes stdout/err in error 

    This converts the initial implementation of a promised exec that used
the customPromisifyArgs support in util.promisify with a custom
implementation. This is because exec and execFile, when there is an
error, still supply the stdout and stderr of the process, and yet
the promisified version with customPromisifyArgs does
not supply this ability.

I created a custom implementation and attached it to exec and execFile
using the util.promisify.custom key.

Fixes: #13364
    @giltayar
    giltayar committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    e44a057 View commit details
    Browse the repository at this point in the history

  2. child_process: refactorings after review comments

    @giltayar
    giltayar committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    e2182e5 View commit details
    Browse the repository at this point in the history

  3. child_process: fixed bug in promisified exec test

    @giltayar
    giltayar committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    6adbd98 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2017

  1. child_process: fixed win compat bug in test

    @giltayar
    giltayar committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    e37cb7e View commit details
    Browse the repository at this point in the history