build,windows: merge test suite groups #13378

refack · 2017-06-01T21:44:52Z

add async-hooks
alphabetize

Refs: #13340
Refs: #13336

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

build,test

refack · 2017-06-01T21:46:35Z

Ref: #13336 (comment)

addaleax

LGTM if it passes CI 🤞

refack · 2017-06-01T21:49:09Z

windows-fanned: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9502/
linter: https://ci.nodejs.org/job/node-test-linter/9521/

refack · 2017-06-01T21:49:39Z

/cc @nodejs/platform-windows @joaocgreis

AndreasMadsen

LGTM, crossing my fingers and toes

refack · 2017-06-01T22:42:28Z

@addaleax @AndreasMadsen so it build but there's a bunch of failed test in /async-hooks/

Want to divvy them up:

=== release test-fseventwrap ===
Path: async-hooks/test-fseventwrap
assert.js:60
  throw new errors.AssertionError({
  ^
AssertionError [ERR_ASSERTION]: Checking invocations at stage "when process exits":

    Never called "destroy", but expected 1 invocation(s).

    at checkHook (D:\code\node\test\async-hooks\hook-checks.js:45:7)

    at Array.forEach (native)

    at checkInvocations (D:\code\node\test\async-hooks\hook-checks.js:28:44)

    at process.onexit (D:\code\node\test\async-hooks\test-fseventwrap.js:32:3)

    at emitOne (events.js:120:20)

    at process.emit (events.js:210:7)

Command: D:\code\node\Release\node.exe D:\code\node\test\async-hooks\test-fseventwrap.js

=== release test-graph.signal ===

Path: async-hooks/test-graph.signal

Mismatched onsigusr2 function calls. Expected exactly 2, actual 0.

    at Object.exports.mustCall (D:\code\node\test\common\index.js:483:10)

    at Object.<anonymous> (D:\code\node\test\async-hooks\test-graph.signal.js:11:30)

    at Module._compile (module.js:569:30)

    at Object.Module._extensions..js (module.js:580:10)

    at Module.load (module.js:503:32)

    at tryModuleLoad (module.js:466:12)

    at Function.Module._load (module.js:458:3)

    at Function.Module.runMain (module.js:605:10)

    at startup (bootstrap_node.js:158:16)

Command: D:\code\node\Release\node.exe D:\code\node\test\async-hooks\test-graph.signal.js

=== release test-pipeconnectwrap ===

Path: async-hooks/test-pipeconnectwrap

assert.js:60

  throw new errors.AssertionError({

  ^
AssertionError [ERR_ASSERTION]: Checking invocations at stage "pipe2, process exiting":

    Never called "destroy", but expected 1 invocation(s).

    at checkHook (D:\code\node\test\async-hooks\hook-checks.js:45:7)

    at Array.forEach (native)

    at checkInvocations (D:\code\node\test\async-hooks\hook-checks.js:28:44)

    at process.onexit (D:\code\node\test\async-hooks\test-pipeconnectwrap.js:98:3)

    at emitOne (events.js:120:20)

    at process.emit (events.js:210:7)

Command: D:\code\node\Release\node.exe D:\code\node\test\async-hooks\test-pipeconnectwrap.js

=== release test-signalwrap ===

Path: async-hooks/test-signalwrap

assert.js:60

  throw new errors.AssertionError({

  ^
AssertionError [ERR_ASSERTION]: one signal wrap when SIGUSR2 handler is set up

    at Object.<anonymous> (D:\code\node\test\async-hooks\test-signalwrap.js:15:8)

    at Module._compile (module.js:569:30)

    at Object.Module._extensions..js (module.js:580:10)

    at Module.load (module.js:503:32)

    at tryModuleLoad (module.js:466:12)

    at Function.Module._load (module.js:458:3)

    at Function.Module.runMain (module.js:605:10)

    at startup (bootstrap_node.js:158:16)

    at bootstrap_node.js:575:3

Command: D:\code\node\Release\node.exe D:\code\node\test\async-hooks\test-signalwrap.js

=== release test-ttywrap.readstream ===

Path: async-hooks/test-ttywrap.readstream

assert.js:60

  throw new errors.AssertionError({

  ^
AssertionError [ERR_ASSERTION]: Checking invocations at stage "when tty ended ":

    Never called "before", but expected 1 invocation(s).

    at checkHook (D:\code\node\test\async-hooks\hook-checks.js:45:7)

    at Array.forEach (native)

    at checkInvocations (D:\code\node\test\async-hooks\hook-checks.js:28:44)

    at common.mustCall (D:\code\node\test\async-hooks\test-ttywrap.readstream.js:29:5)

    at D:\code\node\test\common\index.js:517:15

    at Immediate.ontick (D:\code\node\test\async-hooks\tick.js:7:37)

    at runCallback (timers.js:800:20)

    at tryOnImmediate (timers.js:762:5)

    at processImmediate [as _immediateCallback] (timers.js:733:5)

Command: D:\code\node\Release\node.exe D:\code\node\test\async-hooks\test-ttywrap.readstream.js

=== release test-writewrap ===

Path: async-hooks/test-writewrap

assert.js:60

  throw new errors.AssertionError({

  ^
AssertionError [ERR_ASSERTION]: Checking invocations at stage "when server got secure connection":

    Never called "destroy", but expected 1 invocation(s).

    at checkHook (D:\code\node\test\async-hooks\hook-checks.js:45:7)

    at Array.forEach (native)

    at checkInvocations (D:\code\node\test\async-hooks\hook-checks.js:28:44)

    at checkValidWriteWrap (D:\code\node\test\async-hooks\test-writewrap.js:56:5)

    at Array.forEach (native)

    at checkDestroyedWriteWraps (D:\code\node\test\async-hooks\test-writewrap.js:58:6)

    at Server.onsecureConnection (D:\code\node\test\async-hooks\test-writewrap.js:65:3)

    at Server.<anonymous> (D:\code\node\test\common\index.js:517:15)

    at emitOne (events.js:115:13)

    at Server.emit (events.js:210:7)

Command: D:\code\node\Release\node.exe D:\code\node\test\async-hooks\test-writewrap.js

[00:16|% 100|+  39|-   6]: Done

addaleax · 2017-06-01T22:46:24Z

Sigh. Well, thank you. The sigusr2 ones probably should be skipped, and the first one might be fixed by #13369, but I’m not sure about the other ones.

refack · 2017-06-01T23:00:43Z

Sigh. Well, thank you. The sigusr2 ones probably should be skipped, and the first one might be fixed by #13369, but I’m not sure about the other ones.

So I'll do them all.

refack · 2017-06-01T23:24:46Z

Blocked by #13381 & #13336

refack · 2017-06-02T18:38:55Z

Alphabetized
CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9533/

refack · 2017-06-02T20:05:49Z

On the change to vcbuild.bat, commands from Jenkins
Before:

running 'python tools\test.py --mode=release --run=1,4 -p tap --logfile test.tap doctool inspector known_issues message sequential parallel addons addons-napi --flaky-tests=dontcare'

After

running 'python tools\test.py --mode=release --run=1,4 -p tap --logfile test.tap async-hooks inspector known_issues message parallel sequential doctool addons addons-napi --flaky-tests=dontcare'

joaocgreis

I would prefer the refactor and adding async-hooks in separate commits, but either way LGTM.

kunalspathak · 2017-06-06T22:56:36Z

Thanks for doing this @refack . I noticed this and commented here. At that time I did notice async-hooks test were failing on windows but didn't get time to investigate.

refack · 2017-06-06T22:58:11Z

Thanks for doing this @refack . I noticed this and commented here. At that time I did notice async-hooks test were failing on windows but didn't get time to investigate.

It was your comment that triggered this 👍

PR-URL: nodejs#13378 Refs: nodejs#13340 Refs: nodejs#13336 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: João Reis <[email protected]>

refack · 2017-06-10T17:24:59Z

Landed in df02f39

refack · 2017-06-10T17:30:33Z

Extra sanity test of master of Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9709/

PR-URL: #13378 Refs: #13340 Refs: #13336 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: João Reis <[email protected]>

MylesBorins · 2017-07-17T18:21:41Z

Should we land this on v6.x?

refack · 2017-07-17T23:57:00Z

Yes. Doesn't land cleanly, I'll backport.

nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 1, 2017

refack mentioned this pull request Jun 1, 2017

test: increase coverage of async_hooks #13336

Closed

3 tasks

addaleax approved these changes Jun 1, 2017

View reviewed changes

refack self-assigned this Jun 1, 2017

AndreasMadsen approved these changes Jun 1, 2017

View reviewed changes

refack added the blocked PRs that are blocked by other issues or PRs. label Jun 1, 2017

refack mentioned this pull request Jun 2, 2017

build: streamline JS test suites in Makefile #13340

Closed

2 tasks

joaocgreis approved these changes Jun 6, 2017

View reviewed changes

build: merge test suite groups

df02f39

PR-URL: nodejs#13378 Refs: nodejs#13340 Refs: nodejs#13336 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: João Reis <[email protected]>

refack force-pushed the vcbuild-test-merge branch from b1a8d6d to df02f39 Compare June 10, 2017 17:22

refack merged commit df02f39 into nodejs:master Jun 10, 2017

refack removed the blocked PRs that are blocked by other issues or PRs. label Jun 10, 2017

refack deleted the vcbuild-test-merge branch June 10, 2017 21:23

refack removed their assignment Jun 12, 2017

addaleax pushed a commit that referenced this pull request Jun 12, 2017

build: merge test suite groups

b967b4c

PR-URL: #13378 Refs: #13340 Refs: #13336 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: João Reis <[email protected]>

addaleax mentioned this pull request Jun 12, 2017

v8.1.1 proposal #13598

Merged

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the lts-watch-v6.x label Jul 17, 2017

refack added the backport-requested-v6.x label Jul 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build,windows: merge test suite groups #13378

build,windows: merge test suite groups #13378

refack commented Jun 1, 2017 •

edited

Loading

refack commented Jun 1, 2017

addaleax left a comment

refack commented Jun 1, 2017

refack commented Jun 1, 2017

AndreasMadsen left a comment

refack commented Jun 1, 2017 •

edited

Loading

addaleax commented Jun 1, 2017

refack commented Jun 1, 2017

refack commented Jun 1, 2017 •

edited

Loading

refack commented Jun 2, 2017

refack commented Jun 2, 2017 •

edited by gibfahn

Loading

joaocgreis left a comment

kunalspathak commented Jun 6, 2017

refack commented Jun 6, 2017

refack commented Jun 10, 2017

refack commented Jun 10, 2017

MylesBorins commented Jul 17, 2017

refack commented Jul 17, 2017 •

edited

Loading

build,windows: merge test suite groups #13378

build,windows: merge test suite groups #13378

Conversation

refack commented Jun 1, 2017 • edited Loading

Checklist

Affected core subsystem(s)

refack commented Jun 1, 2017

addaleax left a comment

Choose a reason for hiding this comment

refack commented Jun 1, 2017

refack commented Jun 1, 2017

AndreasMadsen left a comment

Choose a reason for hiding this comment

refack commented Jun 1, 2017 • edited Loading

addaleax commented Jun 1, 2017

refack commented Jun 1, 2017

refack commented Jun 1, 2017 • edited Loading

refack commented Jun 2, 2017

refack commented Jun 2, 2017 • edited by gibfahn Loading

joaocgreis left a comment

Choose a reason for hiding this comment

kunalspathak commented Jun 6, 2017

refack commented Jun 6, 2017

refack commented Jun 10, 2017

refack commented Jun 10, 2017

MylesBorins commented Jul 17, 2017

refack commented Jul 17, 2017 • edited Loading

refack commented Jun 1, 2017 •

edited

Loading

refack commented Jun 1, 2017 •

edited

Loading

refack commented Jun 1, 2017 •

edited

Loading

refack commented Jun 2, 2017 •

edited by gibfahn

Loading

refack commented Jul 17, 2017 •

edited

Loading