Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove building against a shared V8 #1331

Closed
wants to merge 2 commits into from

Conversation

jbergstroem
Copy link
Member

This action is to encourage packagers to not build against a shared V8 library since even minor bumps of V8 can create issues. For people that know what they're doing -- revert this commit.

/R=@bnoordhuis, ?

@mscdex
Copy link
Contributor

mscdex commented Apr 2, 2015

+1

@mscdex mscdex added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 2, 2015
@jbergstroem
Copy link
Member Author

@Fishrock123 Fishrock123 added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 3, 2015
],

'include_dirs': [
'src',
'tools/msvs/genfiles',
'deps/uv/src/ares',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated stylistic change.

This action is to encourage packagers to not build against a
shared V8 library since even minor bumps of V8 can create issues.

For people that know what they're doing, revert this commit.
..also cater for the v8 platform changes
@jbergstroem
Copy link
Member Author

@bnoordhuis this commit re-adds v8 as a dependency to cctest (as well as the main target). Also, add the v8 platform stuff. It's not needed for cctest at the moment, but might as well add it?

@bnoordhuis
Copy link
Member

Agreed and LGTM assuming the CI is happy: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/449/

@jbergstroem
Copy link
Member Author

Looks happy to me.

@chrisdickinson
Copy link
Contributor

This might make the EPEL package harder to maintain down the line, since they strip out all bundled deps; I am not sure if we care about this, though.

@jbergstroem
Copy link
Member Author

@chrisdickinson yeah. I was extra careful so this patch is easily reverted moving forward. If upstream distributions really know what they're doing (which is hard with v8), they should just revert this commit and proceed as usual. They will also run into linking issues with v8_platform. I guess the "nice" thing here would be to create a patch that sorts this out, but at the same time that'd probably be higher quality coming from packagers.

jbergstroem added a commit that referenced this pull request Apr 7, 2015
This action is to encourage packagers to not build against a
shared V8 library since even minor bumps of V8 can create issues.

PR-URL: #1331
Reviewed-By: Ben Noordhuis <[email protected]>
@jbergstroem
Copy link
Member Author

Landed in d726a17. Thanks for the review/comments.

@jbergstroem jbergstroem closed this Apr 7, 2015
@Fishrock123
Copy link
Contributor

I am assuming this is semver-minor... @bnoordhuis would you consider it so?

@bnoordhuis
Copy link
Member

I don't, for the reasons I outlined here. But if other people feel it's semver-minor, that's fine.

@Fishrock123 Fishrock123 removed the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 7, 2015
@rvagg rvagg mentioned this pull request Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants