Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add CTC members to Collaborators list #13284

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 29, 2017

For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

Checklist
Affected core subsystem(s)

doc

@Trott Trott added the doc Issues and PRs related to the documentations. label May 29, 2017
@Trott
Copy link
Member Author

Trott commented May 29, 2017

/cc @evanlucas in case this would adversely affect any of his tooling. (I'm guessing it actually would simplify things.)

@addaleax
Copy link
Member

Looks good, but just to ask … have you considered moving the CTC blocks as they are, just increasing the heading level by 1? That would also make clear who’s a collaborator and has less duplication (which I guess doesn’t matter much but a lot of our brains are wired to avoid that when it comes to code 😄).

@Trott
Copy link
Member Author

Trott commented May 29, 2017

have you considered moving the CTC blocks as they are, just increasing the heading level by 1?

I'm sorry, I don't understand the suggestion here. Can you re-word it or show a short example?

@addaleax
Copy link
Member

I’m basically suggesting to rename ## Current Project Team Members## Collaborators (or so) and dropping the inner ### Collaborators heading. Idk, maybe it’s not a great idea, it just feels more natural to me.

@Trott
Copy link
Member Author

Trott commented May 29, 2017

I’m basically suggesting to rename ## Current Project Team Members → ## Collaborators (or so) and dropping the inner ### Collaborators heading. Idk, maybe it’s not a great idea, it just feels more natural to me.

Ah, I see now!

My main concern is that as the Collaborators list gets longer and longer, it's less and less obvious (when you're scanning the middle of the list) that if you don't find someone, there's another list to look at. So I'd prefer to keep CTC folks listed in the Collaborators list. Basically, if the list is any longer than a typical screen, I think it's best if it's a list that contains everyone. As you scroll, it becomes less obvious that some people aren't listed in the expected place. So just keep it simple and list everyone in their expected place. That's my thinking, anyway.

@jasnell
Copy link
Member

jasnell commented May 30, 2017

With the current structure and role of the CTC being what it is, I'm not a fan of this. I'd much prefer @addaleax's proposed approach.

@Trott
Copy link
Member Author

Trott commented May 30, 2017

With the current structure and role of the CTC being what it is,

I don't understand how this change relates to CTC structure and role. Can you elaborate? (Uh, when you get a chance, that is. I know the next 24 hours or so are pretty busy for you...)

@jasnell
Copy link
Member

jasnell commented May 30, 2017

Right now, it's rather important for it to be pretty clear who the CTC members are. I know this still maintains the separate listing, but then we're just duplicating ourselves which makes this change significantly less valuable.

@richardlau
Copy link
Member

Right now, it's rather important for it to be pretty clear who the CTC members are.

Is there any reason the CTC members list has to be in README.md instead of GOVERNANCE.md? If you're new to the project you pretty much have to read GOVERNANCE.md to understand what the CTC is.

@jasnell
Copy link
Member

jasnell commented May 30, 2017

The visibility of the list makes it far easier to know who needs to sign off on semver-major PRs since those require at least two CTC members to sign off.

@jasnell
Copy link
Member

jasnell commented May 30, 2017

That said, I'd be happy with an approach that eliminates duplication but simplifies the current listing. Like perhaps simply flagging the CTC members in the collaborators list somehow (specific icon perhaps?)

@mhdawson
Copy link
Member

It might make sense to move the CTC members to to top of the list in addition to the icon ?

@MylesBorins
Copy link
Contributor

-1 on moving to the top. I don't think there is anything here about removing the CTC list above

@Trott
Copy link
Member Author

Trott commented May 30, 2017

I know this still maintains the separate listing, but then we're just duplicating ourselves which makes this change significantly less valuable.

I don't understand how duplication makes the change less valuable. I'm bewildered by the desire to avoid duplication of names in two separate lists.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, I am good with this change! Just mentioned what I thought I’d find more intuitive but this makes sense to me either way.

@Trott
Copy link
Member Author

Trott commented Jun 1, 2017

ping @nodejs/collaborators

Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplication isn't ideal, but it's better than being amibiguous.

@mcollina
Copy link
Member

mcollina commented Jun 1, 2017

I think it might be worth adding a (ctc) tag next to the pronoun. This will also help understand people roles if they are just looking at the collab list.

LGTM as it is as well.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
**Trevor Norris** <[email protected]>
* [Trott](https://github.com/Trott) -
**Rich Trott** <[email protected]> (he/him)
>>>>>>> doc: add CTC members to Collaborators list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Fixed.

@Trott Trott force-pushed the lisztomania branch 2 times, most recently from 81a6ff9 to 0a95767 Compare June 4, 2017 15:05
@joyeecheung joyeecheung mentioned this pull request Jun 8, 2017
2 tasks
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.
@Trott
Copy link
Member Author

Trott commented Jul 3, 2017

Landed in bec3877

@Trott Trott closed this Jul 3, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jul 3, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: nodejs#13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: nodejs#13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@addaleax addaleax mentioned this pull request Jul 3, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: #13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: #13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: #13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: #13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: #13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in README. This will avoid confusion about who is and
isn't a Collaborator.

PR-URL: #13284
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
@Trott Trott deleted the lisztomania branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.