v8: back-port openbsd build fix #1318
Conversation
|
LGTM |
|
Could you please put up some details for posterity? |
|
You mean in the commit log? There's not much to the patch but I'll add a line explaining it fixes macro definitions. |
|
@bnoordhuis I mean: what exactly does it fix and why is this is a problem only on OpenBSD? |
|
/cc @jbergstroem |
|
@indutny V8 was picking up the wrong V8_INT64_C and V8_UINT64_C macros on openbsd/amd64. I confess I don't understand why numeric literals need to be |
mscdex
added
build
|
I actually ran into this just yesterday while exploring OpenBSD's make. Confirmed working for 64-bit builds. 32-bit builds still bails for me -- looking into it now. (as a side-note for OpenBSD developers, the libuv test suite could be improved). Edit: Adding LGTM |
Cherry-pick https://codereview.chromium.org/856553002 from upstream. Makes V8 on OpenBSD/amd64 pick up the right V8_INT64_C and V8_UINT64_C macros. PR-URL: nodejs#1318 Refs: nodejs#1312 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
bnoordhuis
force-pushed
the
v8-openbsd-fix
branch
from
47df66e
to
382bd9d
Compare
Cherry-pick https://codereview.chromium.org/856553002 from upstream.
Refs: #1312
R=@indutny? /cc @kaspars @qbit