test: cover dgram handle send failures #13158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
reviewed
May 22, 2017
| return errCode; | ||
| }; | ||
|
|
||
| socket.send('foo', port, 'localhost', callback); |
There was a problem hiding this comment.
I guess it doesn't really matter in this case, but maybe common.localhostIPv4
| assert.strictEqual(err.syscall, 'send'); | ||
| assert.strictEqual(err.address, 'localhost'); | ||
| assert.strictEqual(err.port, port); | ||
| }); |
There was a problem hiding this comment.
Maybe add an assertion for the message format. Something like:
assert.strictEqual(
err.message,
`${err.syscall} ${err.code} ${err.address}:${err.port} ` +
`- Local (${err.localAddress}:${err.localPort})`
);Silly but cheap.
jasnell
approved these changes
May 23, 2017
lpinca
approved these changes
May 23, 2017
This commit adds test coverage for the case where a dgram socket successfully binds, but the handle's send() function fails. PR-URL: nodejs#13158 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
This commit adds test coverage for the case where a dgram socket successfully binds, but the handle's send() function fails. PR-URL: #13158 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
This commit adds test coverage for the case where a dgram socket successfully binds, but the handle's send() function fails. PR-URL: #13158 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test coverage for the case where a dgram socket successfully binds, but the handle's
send()function fails.This was previously covered, but the recent churn in the dgram tests seems to have undone that coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test