-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: redirect-warnings to file, not path #13120
Closed
sam-github
wants to merge
1
commit into
nodejs:master
from
sam-github:clarify-redirect-warnings-usage
Closed
src: redirect-warnings to file, not path #13120
sam-github
wants to merge
1
commit into
nodejs:master
from
sam-github:clarify-redirect-warnings-usage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `file` as name of the argument, as the CLI documentation does.
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
May 19, 2017
mscdex
added
the
cli
Issues and PRs related to the Node.js command line interface.
label
May 19, 2017
cjihrig
approved these changes
May 19, 2017
refack
approved these changes
May 19, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes more sense
lpinca
approved these changes
May 20, 2017
gibfahn
approved these changes
May 20, 2017
jasnell
approved these changes
May 22, 2017
Landed in a886b17 |
addaleax
pushed a commit
that referenced
this pull request
May 23, 2017
Use `file` as name of the argument, as the CLI documentation does. PR-URL: #13120 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 24, 2017
Use `file` as name of the argument, as the CLI documentation does. PR-URL: #13120 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
Use `file` as name of the argument, as the CLI documentation does. PR-URL: #13120 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
3 tasks
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Depends on #10116 which has not yet been backported to 6.x. I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
file
as name of the argument, as the CLI documentation does.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
src,doc?