Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: handle normalized args in normalizeArgs() #13069

Merged
merged 1 commit into from
May 19, 2017
Merged

net: handle normalized args in normalizeArgs() #13069

merged 1 commit into from
May 19, 2017

Commits on May 19, 2017

  1. net: add symbol to normalized connect() args 

    This commit attaches a Symbol to the result of
net._normalizeArgs(). This prevents normal arrays from being
passed to the internal Socket.prototype.connect() bypass logic.

PR-URL: nodejs#13069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @cjihrig
    cjihrig committed May 19, 2017
    Configuration menu
    Copy the full SHA
    51664fc View commit details
    Browse the repository at this point in the history