Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking from toc to subsection for 4.8.x releases #13039

Closed
wants to merge 1 commit into from
Closed

Fix linking from toc to subsection for 4.8.x releases #13039

wants to merge 1 commit into from

Conversation

frlan
Copy link
Contributor

@frlan frlan commented May 15, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 15, 2017
@vsemozhetbyt
Copy link
Contributor

@frlan Thank you!

Dear reviewers, please, let me know if this can be landed without the common delay.

@gibfahn gibfahn self-assigned this May 18, 2017
@gibfahn
Copy link
Member

gibfahn commented May 18, 2017

Linter CI: https://ci.nodejs.org/job/node-test-linter/9162/

@gibfahn
Copy link
Member

gibfahn commented May 18, 2017

Landed in 5de722a

Thanks for the PR @frlan !

@gibfahn gibfahn closed this May 18, 2017
gibfahn pushed a commit that referenced this pull request May 18, 2017
@frlan @gibfahn
doc: fix links from ToC to subsection for 4.8.x
5de722a 
PR-URL: #13039
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@frlan
doc: fix links from ToC to subsection for 4.8.x
b8585e4 
PR-URL: nodejs#13039
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees

@gibfahn gibfahn

Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@frlan @vsemozhetbyt @gibfahn @danbev @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot