Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:refactor test-https-set-timeout-server #13032

Closed
wants to merge 1 commit into from
Closed

test:refactor test-https-set-timeout-server #13032

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 15, 2017

  • Add common.mustCall() for error handlers.
  • Alphabetize modules
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test https

@Trott
test:refactor test-https-set-timeout-server
d13b972 
* Add common.mustCall() for error handlers.
* Alphabetize modules
@Trott Trott added https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. labels May 15, 2017
@Trott
Copy link
Member Author

Trott commented May 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8169/

aqrln
aqrln approved these changes May 19, 2017
View reviewed changes
Copy link
Contributor

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should probably have a space after the colon.

Trott added a commit to Trott/io.js that referenced this pull request May 20, 2017
@Trott
test: refactor test-https-set-timeout-server
658741b 
* Add common.mustCall() for error handlers.
* Alphabetize modules

PR-URL: nodejs#13032
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 20, 2017

Landed in 658741b (with a space added after the colon per @aqrln's comment).

@Trott Trott closed this May 20, 2017
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

@Trott Trott deleted the refactor-https-timeout branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @MylesBorins @refack @jasnell @lpinca @cjihrig @aqrln