Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fixup internal util exports #12998

Closed
wants to merge 1 commit into from
Closed

util: fixup internal util exports #12998

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 12, 2017

util.promisify landed without using the module.exports = {} pattern. This fixes it up for consistency

/cc @addaleax @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@jasnell
util: fixup internal util exports
1d3aee3 
util.promisify landed without using the module.exports = {}
pattern. This fixes it up for consistency
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label May 12, 2017
refack
refack approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is @addaleax call

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/9889/

jasnell added a commit that referenced this pull request May 15, 2017
@jasnell
util: fixup internal util exports
ef16319 
util.promisify landed without using the module.exports = {}
pattern. This fixes it up for consistency

PR-URL: #12998
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented May 15, 2017

Landed in ef16319

@jasnell jasnell closed this May 15, 2017
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@jasnell
util: fixup internal util exports
bb794fb 
util.promisify landed without using the module.exports = {}
pattern. This fixes it up for consistency

PR-URL: nodejs#12998
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @addaleax @refack @lpinca @targos @cjihrig @MylesBorins @nodejs-github-bot