benchmark: chunky http client should exit with 0 #12916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. Fixes: nodejs#12903
nodejs-github-bot
added
benchmark
vsemozhetbyt
approved these changes
May 9, 2017
addaleax
approved these changes
May 9, 2017
cjihrig
approved these changes
May 9, 2017
jasnell
approved these changes
May 9, 2017
|
Landed in 3fa5d80, thanks! |
joyeecheung
added a commit
that referenced
this pull request
May 13, 2017
Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. PR-URL: #12916 Fixes: #12903 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. PR-URL: nodejs#12916 Fixes: nodejs#12903 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.
Fixes: #12903
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, benchmark