Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add skipIfInspectorDisabled to debugger-pid #12882

Closed
wants to merge 2 commits into from
Closed

test: add skipIfInspectorDisabled to debugger-pid #12882

wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 7, 2017

Currently this test will fail if node was configured --without-ssl.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@danbev
test: add skipIfInspectorDisabled to debugger-pid
3521dd0 
Currently this test will fail if node was configured --without-ssl.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 7, 2017
@danbev
Copy link
Contributor Author

danbev commented May 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7928/

Trott
Trott approved these changes May 7, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@mscdex mscdex added the debugger label May 7, 2017
cjihrig
cjihrig approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could move this check right below the require('../common'); line, but it's not necessary.

@danbev
Copy link
Contributor Author

danbev commented May 9, 2017

You could move this check right below the require('../common'); line, but it's not necessary.

Sounds good, I'll move it. Thanks.

danbev added a commit to danbev/node that referenced this pull request May 9, 2017
@danbev
test: add skipIfInspectorDisabled to debugger-pid
f72376d 
Currently this test will fail if node was configured --without-ssl.

PR-URL: nodejs#12882
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented May 9, 2017

Landed in f72376d

@danbev danbev closed this May 9, 2017
@danbev danbev deleted the inspector-check-debugger-pid branch May 9, 2017 10:55
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@danbev
test: add skipIfInspectorDisabled to debugger-pid
b06c8e5 
Currently this test will fail if node was configured --without-ssl.

PR-URL: nodejs#12882
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 20, 2017

Depends on #11631

@gibfahn gibfahn mentioned this pull request Jun 20, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @gibfahn @refack @thefourtheye @Trott @cjihrig @mscdex @nodejs-github-bot