test: fix flaky test-https-client-get-url #12876

sebastianplesciuc · 2017-05-06T20:32:35Z

Fixes test-https-client-get-url by waiting on HTTPS GET
requests to finish before closing the server.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

refack · 2017-05-06T20:56:55Z

@sebastianplesciuc definatly better.
And for the good work I brought you a present: https://ci.nodejs.org/job/node-test-commit/9706/

refack · 2017-05-06T20:58:01Z

@sebastianplesciuc I changed the "Ref" -> "Fixes" in the first comment

You can change it in the commit message, so when this lands, the issue will be closed automatically.

mscdex · 2017-05-06T21:43:35Z

Stress test: https://ci.nodejs.org/job/node-stress-single-test/1202/

jasnell

LGTM if the stress test results look good

mscdex · 2017-05-07T07:38:15Z

I think it's still waiting on a stuck job from earlier today...?

sebastianplesciuc · 2017-05-07T08:02:34Z

@refack Changed the Refs to Fixes in commit message. Thank you!

refack · 2017-05-07T15:23:02Z

New stress: https://ci.nodejs.org/job/node-stress-single-test/1203/

refack · 2017-05-07T19:56:22Z

Stress looks solid.

refack · 2017-05-07T19:57:55Z

CI (macOS only): https://ci.nodejs.org/job/node-test-commit-osx/9624/

addaleax · 2017-05-07T22:49:58Z

@refack Like the CI tells you to, could you please avoid running stress-tests on all platforms unless that’s really necessary?

cjihrig

LGTM with one request.

cjihrig · 2017-05-08T07:25:49Z

test/parallel/test-https-client-get-url.js

@@ -47,12 +47,15 @@ const server = https.createServer(options, common.mustCall(function(req, res) {
  res.writeHead(200, {'Content-Type': 'text/plain'});
  res.write('hello\n');
  res.end();
-  server.close();
 }, 3));

 server.listen(0, function() {


Can you add common.mustCall() here.

@cjihrig Added. Thanks!

thefourtheye · 2017-05-08T15:42:04Z

test/parallel/test-https-client-get-url.js

-  https.get(new URL(u));
-});
+server.listen(0, common.mustCall(() => {
+  const u = `https://127.0.0.1:${server.address().port}/foo?bar`;


Nit: Instead of 127.0.0.1, you can use common.localhostIPv4

@thefourtheye Fixed! Thank you!

Fixed test-https-client-get-url by waiting on HTTPS GET requests to finish before closing the server. Fixes: #12873

Fixed test-https-client-get-url by waiting on HTTPS GET requests to finish before closing the server. PR-URL: nodejs#12876 Fixes: nodejs#12873 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

refack · 2017-05-10T15:13:25Z

Landed in 317180f

refack · 2017-05-10T15:43:49Z

Post land CI:https://ci.nodejs.org/job/node-test-commit/9785/
(Since the CI is on master the one CI job covers three small lands I did almost together.)

Fixed test-https-client-get-url by waiting on HTTPS GET requests to finish before closing the server. PR-URL: nodejs#12876 Fixes: nodejs#12873 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

MylesBorins · 2017-07-17T14:17:28Z

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

sebastianplesciuc · 2017-07-17T18:05:32Z

@MylesBorins This can't be backported.

The test flaked because of multiple https.get requests using both the Legacy and the latest version of url. The version of the test that is in the 6.x-staging branch only has one https.get call: https://github.com/nodejs/node/blob/v6.x-staging/test/parallel/test-https-client-get-url.js

Docs also seem to confirm this, URL in Node 6 LTS vs URL in Node 8.

Please correct me if I'm wrong and also please set the proper labels because I can't :)

MylesBorins · 2017-07-17T19:17:19Z

Thanks @sebastianplesciuc

updated labels

nodejs-github-bot added the test Issues and PRs related to the tests. label May 6, 2017

refack approved these changes May 6, 2017

View reviewed changes

santigimeno approved these changes May 6, 2017

View reviewed changes

refack self-assigned this May 6, 2017

mscdex added the https Issues or PRs related to the https subsystem. label May 6, 2017

jasnell approved these changes May 7, 2017

View reviewed changes

lpinca approved these changes May 7, 2017

View reviewed changes

cjihrig approved these changes May 8, 2017

View reviewed changes

thefourtheye approved these changes May 8, 2017

View reviewed changes

test: fix flaky test-https-client-get-url

d3f29e7

Fixed test-https-client-get-url by waiting on HTTPS GET requests to finish before closing the server. Fixes: #12873

refack closed this May 10, 2017

refack mentioned this pull request May 10, 2017

test: is parallel/test-https-client-get-url flaky on macOS #12873

Closed

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

sebastianplesciuc mentioned this pull request Jun 7, 2017

parallel/test-http-client-get-url - Intermittent on OSX ? #13507

Closed

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

gibfahn added the lts-watch-v6.x label Jun 20, 2017

MylesBorins added the backport-requested-v6.x label Jul 17, 2017

sebastianplesciuc mentioned this pull request Jul 17, 2017

test: fix flaky test-http-client-get-url #13516

Closed

3 tasks

MylesBorins added dont-land-on-v6.x and removed backport-requested-v6.x labels Jul 17, 2017

refack removed their assignment Oct 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix flaky test-https-client-get-url #12876

test: fix flaky test-https-client-get-url #12876

sebastianplesciuc commented May 6, 2017 •

edited by refack

Loading

refack commented May 6, 2017

refack commented May 6, 2017 •

edited

Loading

mscdex commented May 6, 2017

jasnell left a comment

mscdex commented May 7, 2017

sebastianplesciuc commented May 7, 2017

refack commented May 7, 2017

refack commented May 7, 2017

refack commented May 7, 2017

addaleax commented May 7, 2017

cjihrig left a comment

cjihrig May 8, 2017

sebastianplesciuc May 8, 2017

thefourtheye May 8, 2017

sebastianplesciuc May 8, 2017

refack commented May 10, 2017

refack commented May 10, 2017 •

edited

Loading

MylesBorins commented Jul 17, 2017

sebastianplesciuc commented Jul 17, 2017

MylesBorins commented Jul 17, 2017

test: fix flaky test-https-client-get-url #12876

test: fix flaky test-https-client-get-url #12876

Conversation

sebastianplesciuc commented May 6, 2017 • edited by refack Loading

Checklist

Affected core subsystem(s)

refack commented May 6, 2017

refack commented May 6, 2017 • edited Loading

mscdex commented May 6, 2017

jasnell left a comment

Choose a reason for hiding this comment

mscdex commented May 7, 2017

sebastianplesciuc commented May 7, 2017

refack commented May 7, 2017

refack commented May 7, 2017

refack commented May 7, 2017

addaleax commented May 7, 2017

cjihrig left a comment

Choose a reason for hiding this comment

cjihrig May 8, 2017

Choose a reason for hiding this comment

sebastianplesciuc May 8, 2017

Choose a reason for hiding this comment

thefourtheye May 8, 2017

Choose a reason for hiding this comment

sebastianplesciuc May 8, 2017

Choose a reason for hiding this comment

refack commented May 10, 2017

refack commented May 10, 2017 • edited Loading

MylesBorins commented Jul 17, 2017

sebastianplesciuc commented Jul 17, 2017

MylesBorins commented Jul 17, 2017

sebastianplesciuc commented May 6, 2017 •

edited by refack

Loading

refack commented May 6, 2017 •

edited

Loading

refack commented May 10, 2017 •

edited

Loading