Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: turn buffer type-CHECK into exception #12753

Closed
wants to merge 2 commits into from
Closed

src: turn buffer type-CHECK into exception #12753

wants to merge 2 commits into from

Commits on May 3, 2017

  1. src: turn buffer type-CHECK into exception 

    Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: nodejs#12152
    @addaleax
    addaleax committed May 3, 2017
    Configuration menu
    Copy the full SHA
    6ef674f View commit details
    Browse the repository at this point in the history

  2. [squash] fixup test

    @addaleax
    addaleax committed May 3, 2017
    Configuration menu
    Copy the full SHA
    a9e1bba View commit details
    Browse the repository at this point in the history