-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fixup the collaborators list #12750
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry.
addaleax
approved these changes
Apr 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing! This shouldn’t need 48 hours to land, I’d say feel free to go ahead and merge this right away.
TimothyGu
approved these changes
Apr 29, 2017
Landed in 765be6c. |
aqrln
added a commit
that referenced
this pull request
Apr 29, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: #12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: #12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: #12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: #12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 3, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: #12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
sam-github
pushed a commit
that referenced
this pull request
May 15, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: #12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* Add the personal pronoun for @aqrln. * Fix incorrectly ordered @lucamaraschi entry. PR-URL: nodejs/node#12750 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc