(v8.x backport) src: allow CLI args in env with NODE_OPTIONS #12647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12028. Conflict in
doc/api/cli.md
was trivial, caused by docs added adjacent to those introduced in #11968.@jasnell not sure what status of 8.x is, but I request this feature be part of 8.x, and backported to non-maintenance versions (i.e 7.x and 6.x). Its a very useful feature for production, so I'd like it to be available in production Node.js releases.
Not all CLI options are supported, those that are problematic from a
security or implementation point of view are disallowed, as are ones
that are inappropriate (for example, -e, -p, --i), or that only make
sense when changed with code changes (such as options that change the
javascript syntax or add new APIs).
PR-URL: #12028
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Refael Ackermann [email protected]
Reviewed-By: Gibson Fahnestock [email protected]
Reviewed-By: Bradley Farias [email protected]
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)