benchmark: disable dgram benchmark #1258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary measure until dgram no longer calls callbacks synchronously, otherwise this benchmark pegs the CPU at 100% for an indefinite amount of time.
mscdex
added
dgram
|
As you know, I try fixing this issue. but I have not finished. #486 I would like to fix this issue to change the following line from Do you have any thoughts? @bnoordhuis |
|
LGTM |
|
ref: #1313 |
|
Fixed since 18d457b, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary measure until dgram no longer calls callbacks
synchronously, otherwise this benchmark pegs the CPU at 100%
for an indefinite amount of time.