-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in streams.md #12428
Closed
Closed
doc: fix typo in streams.md #12428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
stream
Issues and PRs related to the stream subsystem.
labels
Apr 15, 2017
addaleax
approved these changes
Apr 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good, but can you update the commit message to something like doc: fix typo in streams.md
? If not, that can also be done when merging the PR.
(Also, this doesn’t need to wait 72 hours.)
lpinca
approved these changes
Apr 15, 2017
I believe I just updated it correctly
…On Sat, Apr 15, 2017 at 1:03 PM Luigi Pinca ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12428 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALZAjtU7mOSi4qy2_ha7oZgWvvoIyj_Lks5rwPhwgaJpZM4M-ZdM>
.
|
Landed in a6e4162, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Apr 15, 2017
PR-URL: #12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
PR-URL: #12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
PR-URL: #12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
doc