doc: document the performance team #12213
Conversation
|
@gibfahn thanks but I don't consider myself a performance expert :) gonna remove myself from the team. |
|
I think @mcollina and @trevnorris are good candidates for the team instead. |
|
I've just request access. |
|
Also @petkaantonov if he is still active. |
|
One last: @benjamingr, sorry about the spam. P.S. I'm probably missing other good candidates :) |
| @@ -27,6 +27,7 @@ | |||
| | `test/*` | @nodejs/testing | | |||
| | `tools/eslint`, `.eslintrc` | @not-an-aardvark, @silverwind, @trott | | |||
| | async_hooks | @nodejs/diagnostics | | |||
| | performance | @nodejs/performance | | |||
There was a problem hiding this comment.
Just noticed.. should we replace the row for benchmark/* above too?
There was a problem hiding this comment.
I considered it, but I'm not sure. That's probably a question for @nodejs/benchmarking.
There was a problem hiding this comment.
It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks
|
Maybe @fhinkel would be interested. |
|
Sure |
|
Added all the people mentioned, that way they can leave if they want. EDIT: You're all team maintainers, so if you want to add someone go for it!
@lpinca The idea isn't that these are a list of performance experts (otherwise it'd probably be a short list 😁 ). It's just to have a list of people who are willing to look at performance issues and PRs. Feel free to remove yourself if you want, but being in the team doesn't mean you have to approve PRs or anything. |
| @@ -27,6 +27,7 @@ | |||
| | `test/*` | @nodejs/testing | | |||
| | `tools/eslint`, `.eslintrc` | @not-an-aardvark, @silverwind, @trott | | |||
| | async_hooks | @nodejs/diagnostics | | |||
| | performance | @nodejs/performance | | |||
There was a problem hiding this comment.
It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks
mscdex
added
the
performance
Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs#12213 Refs: nodejs#12194 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs#12213 Refs: nodejs#12194 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Can be cc'ed with `@nodejs/performance`. PR-URL: #12213 Refs: #12194 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Can be cc'ed with `@nodejs/performance`. PR-URL: #12213 Refs: #12194 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs/node#12213 Refs: nodejs/node#12194 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Can be cc'ed with
@nodejs/performance.I added some people: @mscdex @vsemozhetbyt @joyeecheung @TimothyGu @lpinca
If anyone else wants to join and be cc/ed on issues, feel free to request access (or remove yourself if you don't want to be on the team).
Link to team
Refs: #12194 (comment)
Checklist
Affected core subsystem(s)