-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: move the Code of Conduct to TSC repository #12147
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
meta
Issues and PRs related to the general management of the project.
labels
Mar 31, 2017
richardlau
approved these changes
Mar 31, 2017
gibfahn
approved these changes
Mar 31, 2017
@nodejs/tsc ... I need TSC member sign off on this please :-) |
cjihrig
approved these changes
Apr 4, 2017
nebrius
approved these changes
Apr 4, 2017
addaleax
approved these changes
Apr 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but for now this is blocked until nodejs/TSC#232 lands
jasnell
added a commit
that referenced
this pull request
Apr 17, 2017
PR-URL: #12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Landed in 258494c |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
PR-URL: #12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
PR-URL: #12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gibfahn
added
land-on-v6.x
and removed
blocked
PRs that are blocked by other issues or PRs.
labels
May 15, 2017
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2017
PR-URL: #12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12147 Ref: nodejs/TSC#224 Ref: nodejs/TSC#232 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion and decision on the last TSC call. Moves the the Code of Conduct to the TSC repository.
nodejs/TSC#232 should land first.
Requires @nodejs/tsc signoff.
Refs: nodejs/TSC#224
Refs: nodejs/TSC#232
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
meta