test: mark child-process-exec-kill-throws flaky #12054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
added
child_process
|
CI: https://ci.nodejs.org/job/node-test-commit/8698/ EDIT: Windows seems to be green. |
cjihrig
approved these changes
Mar 27, 2017
santigimeno
approved these changes
Mar 27, 2017
jasnell
approved these changes
Mar 27, 2017
|
I'd prefer to get this landed sooner than later so we can unbreak CI |
richardlau
approved these changes
Mar 27, 2017
|
Landing... |
gibfahn
force-pushed
the
flaky-exec-kill-win
branch
from
9a475b9
to
3c9d6ff
Compare
PR-URL: nodejs#12054 Ref: nodejs#12053 Ref: nodejs#11038 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
gibfahn
force-pushed
the
flaky-exec-kill-win
branch
from
3c9d6ff
to
66e7dc5
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
PR-URL: #12054 Ref: #12053 Ref: #11038 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #12053
Refs: #11038
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
cc/ @cjihrig @nodejs/testing @nodejs/platform-windows