Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: minor fixups for REPL eval tests #11946

Closed
wants to merge 1 commit into from
Closed

test: minor fixups for REPL eval tests #11946

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

The process.on("exit") event handlers are unnecessary, so it’s okay
to drop them.

Ref: #11871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,repl

@addaleax
test: minor fixups for REPL eval tests
3859673 
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

Ref: nodejs#11871
@addaleax addaleax added dont-land-on-v4.x repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels Mar 20, 2017
Fishrock123
Fishrock123 approved these changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/6959/

jasnell pushed a commit that referenced this pull request Mar 22, 2017
@addaleax @jasnell
test: minor fixups for REPL eval tests
64d0a73 
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

PR-URL: #11946
Ref: #11871
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

Landed in 64d0a73

@jasnell jasnell closed this Mar 22, 2017
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @jasnell @evanlucas @Fishrock123 @cjihrig