url: spec-compliant URLSearchParams parser #11858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
querystring
|
Rerun of CI after last commit: https://ci.nodejs.org/job/node-test-pull-request/6855/ |
jasnell
approved these changes
Mar 16, 2017
|
@mscdex, I'd like you to take a look at this if possible since you wrote the optimized |
joyeecheung
approved these changes
Mar 16, 2017
watilde
approved these changes
Mar 17, 2017
|
Unless there are any additional comments (ping @mscdex) I'm going to merge this tomorrow. |
TimothyGu
added a commit
that referenced
this pull request
Mar 22, 2017
PR-URL: #11858 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
TimothyGu
added a commit
that referenced
this pull request
Mar 22, 2017
The entire `URLSearchParams` class is now fully spec-compliant. PR-URL: #11858 Fixes: #10821 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
|
Landed in a1028d5...c515a98. |
|
this will need to be manually backported to v7.x |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance is also drastically improved, so that
URLSearchParamsis on average 150% faster thanquerystring.parse.The
URLSearchParamsparser is in fact forked from thequerystring.parse, with the following changes:keyandvaluevariables are now merged into onebufsepandeqis removedlastPoswas formerly used for two different purposes: as the starting position of a pair and as the (index + 1) of the last-added buffer; split it into two variablesSome of these changes may be able to be backported to
querystring. In particular, 4 and 5 may fix actual bugs in the querystring implementation (e.g. currentlyquerystring.parse('+') => {}). I will investigate that after this PR is landed.After this PR, the
URLSearchParamsclass will be fully spec-compliant 🎉Fixes: #10821
Benchmark: before vs. after (avg. 240% improvement)
Benchmark: legacy (
querystring) vs. WHATWG (avg. 150% improvement)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
querystring, url