Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRYPTO: Add configure option to use system CA certificates #11774

Closed
wants to merge 1 commit into from

Conversation

sgallagher
Copy link
Contributor

This patch allows distribution packagers to pass a
--system-ca-certificates argument to ./configure in order to
specify a CA certificate bundle file on the system on which Node
will be installed. If this argument is passed, Node will only
use the system CA certificates and not its internal built-in ones,
though they can still be extended through the use of the
NODE_EXTRA_CA_CERTS environment variable.

Signed-off-by: Stephen Gallagher [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

This patch allows distribution packagers to pass a
`--system-ca-certificates` argument to `./configure` in order to
specify a CA certificate bundle file on the system on which Node
will be installed. If this argument is passed, Node will *only*
use the system CA certificates and not its internal built-in ones,
though they can still be extended through the use of the
NODE_EXTRA_CA_CERTS environment variable.

Signed-off-by: Stephen Gallagher <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Mar 9, 2017
@sgallagher
Copy link
Contributor Author

This should be a proper solution for #4175

@sgallagher
Copy link
Contributor Author

Hmm, I just saw that something landed in Node.js 7.5.0 that is similar...

@sgallagher sgallagher closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants