test: remove unneeded eslint-disable comment #11679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
hiroppy
approved these changes
Mar 3, 2017
cjihrig
approved these changes
Mar 3, 2017
gibfahn
approved these changes
Mar 3, 2017
test-url-format has the max-len rule disabled by a comment but doesn't have any lines that violate the max-len lint rule. Remove the comment. Reformat other comments for capitalization, punctuation, and updated URLs.
Cleaned up a few comments. Thanks. |
gibfahn
approved these changes
Mar 4, 2017
addaleax
approved these changes
Mar 4, 2017
watilde
approved these changes
Mar 4, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 6, 2017
test-url-format has the max-len rule disabled by a comment but doesn't have any lines that violate the max-len lint rule. Remove the comment. Reformat other comments for capitalization, punctuation, and updated URLs. PR-URL: nodejs#11679 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
|
Landed in 60c8115 |
|
This is not landing cleanly on v7.x-staging. Feel free to send a backport PR. Thanks! |
3 tasks
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-url-format has the max-len rule disabled by a comment but doesn't
have any lines that violate the max-len rule. Remove the comment.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test url