Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove outdated FIXME in node_crypto.cc #11669

Closed
wants to merge 1 commit into from
Closed

src: remove outdated FIXME in node_crypto.cc #11669

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Mar 3, 2017

Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: #4641

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove outdated FIXME in node_crypto.cc
a463abb 
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: nodejs#4641
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Mar 3, 2017
@gibfahn gibfahn requested a review from bnoordhuis March 3, 2017 10:21
gibfahn
gibfahn approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on #4641 (comment)

danbev added a commit to danbev/node that referenced this pull request Mar 4, 2017
@danbev
src: remove outdated FIXME in node_crypto.cc
9352528 
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: nodejs#4641
PR-URL: nodejs#11669
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Mar 4, 2017

Landed in 9352528

@danbev danbev closed this Mar 4, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
@danbev @addaleax
src: remove outdated FIXME in node_crypto.cc
821d713 
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: #4641
PR-URL: #11669
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
Merged
@danbev danbev deleted the remove-out-of-date-fixme branch March 10, 2017 06:47
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@danbev @MylesBorins
src: remove outdated FIXME in node_crypto.cc
c283682 
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: #4641
PR-URL: #11669
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@danbev @MylesBorins
src: remove outdated FIXME in node_crypto.cc
1035967 
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: #4641
PR-URL: #11669
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@danbev @andrew749
src: remove outdated FIXME in node_crypto.cc
ea7bde1 
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.

Refs: nodejs/node#4641
PR-URL: nodejs/node#11669
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aliscco aliscco mentioned this pull request Jun 23, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Jan 9, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @bnoordhuis @jasnell @cjihrig @gibfahn @MylesBorins @nodejs-github-bot