Update AUTHORS list to reflect new contributions. #11533
Conversation
nodejs-github-bot
added
the
meta
|
It seems like this adds many duplicate entries (I immediately noticed Ron Korving, Anna Henningsen, Michaël Zasso, and there are probably others...) EDIT: Imran Iqbal, Minqi Pan/P.S.V.R., ChALkeR and no doubt many more duplicates.... |
|
See #9352 for some duplicate resolutions. |
|
Many of the changes to the existing names should also be reverted. The update should only include the newly added entries that are not duplicates. |
|
@jasnell Thanks. Will do it asap. |
|
Thank you @aashil. It is quite helpful for you to do this and very much appreciated. |
|
@jasnell No problem. Should I consider email changes for existing authors? For example, |
|
For those, it's best to at-mention the person in question and ask what they would prefer. |
aashil
force-pushed
the
update-authors
branch
from
219e573
to
6861a22
Compare
|
The below users might want to use a different name or email. Also, check if you have a duplicate entry with a different name or email in the list. Please let me know and I will update the .mailmap @ChALkeR |
|
I guess there is a limit to tag people. Please look at the above comment. @jBarz |
AUTHORS
Outdated
| Oscar Morrison <[email protected]> | ||
| Jaideep Bajwa <[email protected]> | ||
| timathon <[email protected]> | ||
| Timothy <[email protected]> |
There was a problem hiding this comment.
Timothy Leverett <[email protected]>
Thanks
AUTHORS
Outdated
| kobelb <[email protected]> | ||
| coderaiser <[email protected]> | ||
| Pedro Victor <[email protected]> | ||
| jedireza <[email protected]> |
There was a problem hiding this comment.
Reza Akhavan [email protected]
AUTHORS
Outdated
| Yann Pringault <[email protected]> | ||
| Evan Torrie <[email protected]> | ||
| Michael Lefkowitz <[email protected]> | ||
| vitkarpov <[email protected]> |
There was a problem hiding this comment.
Viktor Karpov [email protected]
AUTHORS
Outdated
| toboid <[email protected]> | ||
| Shubheksha Jalan <[email protected]> | ||
| jobala <[email protected]> | ||
| asafdav2 <[email protected]> |
There was a problem hiding this comment.
Asaf David [email protected]
AUTHORS
Outdated
| Daiki Arai <[email protected]> | ||
| ALJCepeda <[email protected]> | ||
| Sebastian Roeder <[email protected]> | ||
| toboid <[email protected]> |
There was a problem hiding this comment.
Toby Stableford [email protected]
AUTHORS
Outdated
| Michael Macherey <[email protected]> | ||
| Sudaraka Wijesinghe <[email protected]> | ||
| Miguel Angel Asencio Hurtado <[email protected]> | ||
| ss22ever <[email protected]> |
AUTHORS
Outdated
| sarahmeyer <[email protected]> | ||
| Fumiya KARASAWA <[email protected]> | ||
| Jesús Leganés-Combarro 'piranna <[email protected]> | ||
| jBarz <[email protected]> |
There was a problem hiding this comment.
John Barboza [email protected]
AUTHORS
Outdated
| Jay Brownlee <[email protected]> | ||
| Outsider <[email protected]> | ||
| Sarah Meyer <[email protected]> | ||
| anoff <[email protected]> |
There was a problem hiding this comment.
Andreas Offenhaeuser <[email protected]>
There was a problem hiding this comment.
Ben Lugavere [email protected]
AUTHORS
Outdated
| Aaron Bieber <[email protected]> | ||
| Gerges Beshay <[email protected]> | ||
| Isobel Redelmeier <[email protected]> | ||
| kobelb <[email protected]> |
There was a problem hiding this comment.
Brandon Kobel [email protected]
AUTHORS
Outdated
| Yosuke Saito <[email protected]> | ||
| mkamakura <[email protected]> | ||
| kalrover <[email protected]> | ||
| brad-decker <[email protected]> |
There was a problem hiding this comment.
Brad Decker [email protected]
AUTHORS
Outdated
| solebox <[email protected]> | ||
| John Vilk <[email protected]> | ||
| Tyler Brazier <[email protected]> | ||
| marzelin <[email protected]> |
There was a problem hiding this comment.
Marcin Zielinski [email protected]
My entry in the |
AUTHORS
Outdated
| Sarah Meyer <[email protected]> | ||
| anoff <[email protected]> | ||
| Sean Villars <[email protected]> | ||
| k3kathy <[email protected]> |
There was a problem hiding this comment.
Kathy Truong [email protected]
AUTHORS
Outdated
| Vinícius do Carmo <[email protected]> | ||
| Birunthan Mohanathas <[email protected]> | ||
| John Barboza <[email protected]> | ||
| richnologies <[email protected]> |
There was a problem hiding this comment.
Ricardo Sánchez Gregorio [email protected]
Thanks
|
Jon Tippens Thanks |
AUTHORS
Outdated
| Dan Fabulich <[email protected]> | ||
| Mike Ralphson <[email protected]> | ||
| Alexis374 <[email protected]> | ||
| atstojanov <[email protected]> |
There was a problem hiding this comment.
Angel Stoyanov [email protected]
|
@fhinkel On taking a close look at the script, I found that it is designed to exclude all users with https://github.com/nodejs/node/blob/master/tools/update-authors.sh#L11 PS. Who is |
|
Ping @rvagg ... he may have the context for the |
|
I'm assuming we didn't want to count V8 commits (looks like they were imported differently at some point?), AFAIK Erik was on the V8 team. I can change my email address. Sorry for causing confusion by reviewing and committing with different addresses. |
@fhinkel looking at the |
| Vincent Voyer <[email protected]> | ||
| Vladimir de Turckheim <[email protected]> | ||
| vsemozhetbyt <[email protected]> Vse Mozhet Byt <[email protected]> |
There was a problem hiding this comment.
Using Vse's real name would probably be preferred.
There was a problem hiding this comment.
Or maybe not the real name 😉, but at least spelled out is better than a network handle
There was a problem hiding this comment.
Not sure if I should change that. The original author list had it this way. cc @vsemozhetbyt
There was a problem hiding this comment.
It is not a real name, it's a nickname, something like 'anything is possible', 'anything can happen', 'you never know', 'you never can tell' in Russian :) I am OK with either variant, but 'Vse' would be a bit arrogant of me :) — it is actually 'everything, all, everybody' in Russian ) Sorry for the mess) I think it is OK as it is)
There was a problem hiding this comment.
[off topic] what is .mailmap used for?
There was a problem hiding this comment.
Sometimes people use different name and/or email address in their commits. Mailmap is a way to keep track of that person's preferred username and email address and all the other usernames and email addresses used.
Trott
dismissed
their stale review
Wow! Thanks for sticking with this! (Was this a NodeTodo thing? I can't remember that far back! :-D)
|
@Trott No problem! This was actually the first issue/work I found myself after the NodeTodo thing. Looking forward to major contributions in the future. Thanks for all the help. |
|
I'll get this landed |
PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in 9d3c06c |
|
@jasnell Just wanted to understand what you did for merging. Did you squashed all my commits and then cherry-picked to origin/master? |
|
The workflow is fairly straightforward... I use |
PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
@aashil, we have a nice step-by-step patch application process documented in COLLABORATOR_GUIDE.md. |
PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs/node#11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Update the
AUTHORSlist.Fixes #11526
Fixes #6403