Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enhance test-common.js #11433

Closed
wants to merge 1 commit into from
Closed

test: enhance test-common.js #11433

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 16, 2017

  • refactor test-common.js so that global leak detection does not need to
    be disabled
  • add test for common.fail()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott
test: enhance test-common.js
a045e74 
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()
@Trott Trott added the test Issues and PRs related to the tests. label Feb 16, 2017
@mscdex
Copy link
Contributor

mscdex commented Feb 17, 2017 •
edited
Loading

Perhaps we should also add a test or two for common.mustNotCall()?

@targos
Copy link
Member

targos commented Feb 18, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6489/

jasnell pushed a commit that referenced this pull request Feb 19, 2017
@Trott @jasnell
test: enhance test-common.js
7b76f82 
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()

PR-URL: #11433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 19, 2017

Landed in 7b76f82

@jasnell jasnell closed this Feb 19, 2017
addaleax pushed a commit that referenced this pull request Feb 22, 2017
@Trott @addaleax
test: enhance test-common.js
a523482 
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()

PR-URL: #11433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

This would need a backport PR to land in v6 or v4

@Trott Trott deleted the minor branch January 13, 2022 22:34
This was referenced Jul 6, 2023
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Jul 10, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
@leonardoadame leonardoadame mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 5, 2023
Open
@aliscco aliscco mentioned this pull request Dec 8, 2023
Open
This was referenced Dec 10, 2023
Open
Open
This was referenced Dec 10, 2023
Open
Open
@leonardoadame leonardoadame mentioned this pull request Dec 19, 2023
Open
@aliscco aliscco mentioned this pull request Jan 1, 2024
Open
@aliscco aliscco mentioned this pull request Jan 31, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Feb 12, 2024
Open
@leonardoadame leonardoadame mentioned this pull request May 13, 2024
Open
@aliscco aliscco mentioned this pull request May 15, 2024
Open
@leonardoadame leonardoadame mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @mscdex @targos @jasnell @santigimeno @lpinca @cjihrig @gibfahn