src: do not leak handles on debug and exit #1133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure HandleScope is created before creating any new handles (which `Context::Scope` and `Environment::GetCurrent` does).
|
Nice! (And obvious in retrospect. :-)) LGTM. |
|
Thanks! |
|
sweet, LGTM, but sadly I don't imagine these particular ones would impact the apparent leak in #1075 unless I'm missing something |
|
LGTM |
indutny
added a commit
that referenced
this pull request
Mar 12, 2015
Ensure HandleScope is created before creating any new handles (which `Context::Scope` and `Environment::GetCurrent` does). PR-URL: #1133 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Landed in e2c9040, thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure HandleScope is created before creating any new handles (which
Context::ScopeandEnvironment::GetCurrentdoes).cc @iojs/collaborators @trevnorris @bnoordhuis
I have identified these with the help of : https://codereview.chromium.org/985873002/