-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: separate altname extensions with ", " #113
Conversation
In newly introduced `SafeX509ExtPrint` I forgot to insert separators between extensions, which lead to the "DNS:...DNS:..." thing for npm. Fix nodejs#105
Hello! I am pleased to see your valuable contribution to this project. Would you Questions:
Please provide the answers in an ordered list like this:
Note that I am just a bot with a limited human-reply parsing abilities, In case of success I will say: In case of validation problem I will say: Truly yours, Responsibilities
|
|
...summoning the core team devs! |
LGTM |
Landed in 687dfc9, thank you! |
In newly introduced
SafeX509ExtPrint
I forgot to insert separatorsbetween extensions, which lead to the "DNS:...DNS:..." thing for npm.
Fix #105
For @caineio: