Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-dgram-setBroadcast.js #11252

Closed
wants to merge 1 commit into from
Closed

test: refactor test-dgram-setBroadcast.js #11252

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 9, 2017

This test wasn't actually working, as sockets were being closed, allowing the test to exit before any assertions were actually run. This commit refactors the test to maintain the same intended semantics.

If anyone is curious, I found this while looking at the code coverage report.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjihrig
test: refactor test-dgram-setBroadcast.js
81671e9 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 9, 2017
@Trott
Copy link
Member

Trott commented Feb 9, 2017

I don't think test-dgram-membership is afflicted with the same issue, but is it worth refactoring out its identical setup() anyway as a precaution or anything? (I have no opinion either way.)

Trott
Trott approved these changes Feb 9, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 9, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

@Trott it looks like test-dgram-membership is fine. I'll probably update it a little bit to at least improve the error message checking with assert.throws().

The problem with this test isn't setup(). The problem here is that the test would synchronously call bind() and then teardown the socket. At least on my machine, this means that nothing was keeping the event loop open, and the code inside the bind() callback was never getting a chance to execute. This seems to be the case on the machine where code coverage was running as well.

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6322/

jasnell pushed a commit that referenced this pull request Feb 11, 2017
@cjihrig @jasnell
test: refactor test-dgram-setBroadcast.js
fe2b5f0 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: #11252
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 11, 2017

Landed in fe2b5f0

@jasnell jasnell closed this Feb 11, 2017
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@cjihrig @italoacasas
test: refactor test-dgram-setBroadcast.js
786b859 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: #11252
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: refactor test-dgram-setBroadcast.js
809aea3 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: nodejs#11252
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@cjihrig @krydos
test: refactor test-dgram-setBroadcast.js
aed9f60 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: nodejs#11252
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@cjihrig @jasnell
test: refactor test-dgram-setBroadcast.js
7550a3b 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: #11252
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

would need a backport PR to land in v4

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: refactor test-dgram-setBroadcast.js
7596049 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: #11252
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @Trott @jasnell @mscdex @nodejs-github-bot