Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable no-throw-literal ESLint rule #11168

Closed
wants to merge 2 commits into from
Closed

tools: enable no-throw-literal ESLint rule #11168

wants to merge 2 commits into from

Commits on Feb 4, 2017

  1. test: throw Error objects instead of literals 

    test-tls-econnreset and test-http-response-status-message throw literals
instead of Error objects. Use common.fail() which throws an
AssertionError.
    @Trott
    Trott committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    4c2f041 View commit details
    Browse the repository at this point in the history

  2. tools: enable no-throw-literal ESLint rule 

    Only throw the Error object itself or an object using the Error object
as base objects for user-defined exceptions.
    @Trott
    Trott committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    bbd1af3 View commit details
    Browse the repository at this point in the history