Revert broken commits #11155
Closed
Revert broken commits #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 907ce8d.
|
It looks like the File URL commit is failing also. Will revert that one too |
This reverts commit 79400bf.
4 tasks
jasnell
changed the title
TimothyGu
approved these changes
Feb 4, 2017
|
CI looking good. will land as soon as it completes |
jasnell
added a commit
that referenced
this pull request
Feb 4, 2017
This reverts commit 907ce8d. PR-URL: #11155 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 4, 2017
This reverts commit 79400bf. PR-URL: #11155 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
|
The file URL commit appears to be flaky on windows, does not always fail. I'll keep investigating. Landed in 9562bf4...5e52a9a |
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
This reverts commit 907ce8d. PR-URL: nodejs#11155 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
This reverts commit 79400bf. PR-URL: nodejs#11155 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears I somehow inadvertently was looking at the wrong CI results when evaluating this one for landing. Looks like it broke CI. We should do a quick revert.
Reverts: #11096
Reverts: #10739
/cc @mhdawson
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)