Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add debug message for invalid header value #11073

Closed
wants to merge 1 commit into from
Closed

http: add debug message for invalid header value #11073

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

This makes it easier to see what header has an invalid value.

PR-URL: #9195
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Sakthipriyan Vairamani [email protected]
Reviewed-By: Brian White [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http

This is a backport of #9195 to v6.x.

/cc @MylesBorins

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v6.x labels Jan 30, 2017
@evanlucas
http: add debug message for invalid header value
be92c42 
This makes it easier to see what header has an invalid value.

PR-URL: nodejs#9195
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Brian White <[email protected]>
@evanlucas
Copy link
Contributor Author

Rebased against latest v6.x-staging.

@jasnell
Copy link
Member

jasnell commented Feb 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6460/

@MylesBorins
Copy link
Contributor

landed in c359018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evanlucas @jasnell @MylesBorins @lpinca @nodejs-github-bot