src: remove usage of V8 deprecated APIs in node_url.cc #11066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
TimothyGu
changed the title
TimothyGu
changed the title
targos
reviewed
Jan 29, 2017
src/node_url.cc
Outdated
| @@ -1316,7 +1318,8 @@ namespace url { | |||
| Utf8Value input(env->isolate(), args[0]); | |||
| enum url_parse_state override = kUnknownState; | |||
| if (args[1]->IsNumber()) | |||
| override = (enum url_parse_state)(args[1]->Uint32Value()); | |||
| override = (enum url_parse_state)( | |||
| args[1]->Uint32Value(env->context()).ToChecked()); | |||
There was a problem hiding this comment.
We use FromJust in the code base
src/node_url.cc
Outdated
| @@ -1316,7 +1318,8 @@ namespace url { | |||
| Utf8Value input(env->isolate(), args[0]); | |||
| enum url_parse_state override = kUnknownState; | |||
| if (args[1]->IsNumber()) | |||
There was a problem hiding this comment.
I'd add braces here for clarity now that it expands on two lines
addaleax
approved these changes
Jan 29, 2017
src/node_url.cc
Outdated
| override = (enum url_parse_state)(args[1]->Uint32Value()); | ||
| if (args[1]->IsNumber()) { | ||
| override = (enum url_parse_state)( | ||
| args[1]->Uint32Value(env->context()).FromJust()); |
There was a problem hiding this comment.
Can you turn this into a reinterpret_cast and rename override to something that’s not a language keyword?
There was a problem hiding this comment.
Turns out static_cast works but reinterpret_cast doesn't. override bit fixed.
jasnell
approved these changes
Jan 30, 2017
Also: - Avoid using 'override' as variable name - Use explicit static_cast instead of C-style cast
TimothyGu
force-pushed
the
url-cpp-deprecated
branch
from
7edd9ed
to
58cc121
Compare
targos
approved these changes
Jan 31, 2017
|
New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/6127/ |
|
Some failures in that last CI run, trying again: https://ci.nodejs.org/job/node-test-pull-request/6138/ |
|
Landed in c7e1be8. |
TimothyGu
added a commit
that referenced
this pull request
Feb 1, 2017
Also: - Avoid using 'override' as variable name - Use explicit static_cast instead of C-style cast PR-URL: #11066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 2, 2017
Also: - Avoid using 'override' as variable name - Use explicit static_cast instead of C-style cast PR-URL: nodejs#11066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Also: - Avoid using 'override' as variable name - Use explicit static_cast instead of C-style cast PR-URL: nodejs#11066 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/6097/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url