Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix broken assertion #10840

Closed
wants to merge 1 commit into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 16, 2017

This commit fixes a broken assertion in test-cli-eval.js. b9adbf2 introduced the break, and was landed even though CI showed that the test failed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 16, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 16, 2017

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Jan 16, 2017
This commit fixes a broken assertion in test-cli-eval.js.
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 16, 2017

CI is green. May want to fast track this to unbreak the CI.

@italoacasas
Copy link
Contributor

+1 for fast tracking this

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, landing

@addaleax
Copy link
Member

Landed in 38ae95b

@addaleax addaleax closed this Jan 17, 2017
addaleax pushed a commit that referenced this pull request Jan 17, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: #10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 17, 2017

btw, my apologies on this. I'd completely missed the breakage there somehow.

@cjihrig cjihrig deleted the broken-test branch January 17, 2017 02:13
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: nodejs#10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jan 28, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: #10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: nodejs#10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: nodejs#10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: #10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: #10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
This commit fixes a broken assertion in test-cli-eval.js.

PR-URL: nodejs/node#10840
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants