Eslint fixes #10771
Eslint fixes #10771
Conversation
nodejs-github-bot
added
tools
sam-github
force-pushed
the
eslint-fixes
branch
from
fc161ad
to
e0c6ba4
Compare
|
@Trott Sorry, I was careless and I broke the jslint target by not reconfirming CI was green after my final rebase before merge.
|
|
@nodejs/ctc |
|
The test change LGTM. What's up with the eslint change? Also, can you link to the PR that broke the CI. |
|
#10389 <--- I linked to the commit in
Its a reapplication of #9299, which you LGTMed. However the eslint tools is getting vendored into node isn't working well. |
|
The two commits are related, because |
|
Is it OK if I land them immediately, without waiting 48 hours? |
Reapplication of #9299 since the symlink was re-added in f44969a. PR-URL: #10771 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fix lint error introduced in ea72331 PR-URL: #10771 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Reapplication of nodejs#9299 since the symlink was re-added in f44969a. PR-URL: nodejs#10771 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fix lint error introduced in ea72331 PR-URL: nodejs#10771 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
@sam-github this hasn't been backported yet right? LMK if you want it to land on v6.x. |
|
So, nothing to do here. |
|
marked as landed on 6.x because it has |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, eslint