test: Revert add option to use node in path #10613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
tools
evanlucas
suggested changes
Jan 4, 2017
|
@evanlucas But that exceeds the 50 chars limit. Is that okay? |
Fishrock123
approved these changes
Jan 4, 2017
There was a problem hiding this comment.
+1 to @evanlucas's comemnt, this should be made via git revert unless there is some other issue.
Please merge some form of this ASAP.
|
@thefourtheye I think so for reverts. I would wager it's happened before. |
|
@thefourtheye yes. It should just be with |
This reverts commit 4198253.
thefourtheye
force-pushed
the
revert-tools-test
branch
from
9cc20d1
to
a3c8fac
Compare
|
@evanlucas @Fishrock123 Thanks 👍 Updated the commit. |
|
Oy good catch. Missed that entirely on my initial review. LGTM |
gibfahn
approved these changes
Jan 4, 2017
evanlucas
approved these changes
Jan 4, 2017
|
Landed in 26bf954 |
thefourtheye
added a commit
that referenced
this pull request
Jan 4, 2017
This reverts commit 4198253. PR-URL: #10613 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
jbergstroem
reviewed
Jan 4, 2017
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
This reverts commit 4198253. PR-URL: nodejs#10613 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools
Description
This reverts commit 4198253, landed in
#9674.
This fails at
File "tools/test.py", line 1429, in ProcessOptions
options.j = int(cores) if cores is not None else
multiprocessing.cpu_count()
with the error
NotImplementedError: cannot determine number of cpus
from
File "...multiprocessing/init.py", line 136, in cpu_count
raise NotImplementedError('cannot determine number of cpus')
on MacOS machines.