-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] meta: update copyright statements #10599
Conversation
@mikeal Can we get the legal team to review and sign-off on the new header ASAP? I don't want to be stuck with this massive header for the next 6 months waiting for the legal committee to review this. Especially since they're known to take their sweet time. @bnoordhuis I've been told you're actually going to be speaking w/ the legal team directly. If this is correct, can you also bring up the need to immediately review the new header? |
@rvagg I was told you're the only other one that has access to the legal team. Can you also put pressure on the legal team, or let me know how I can communicate w/ them directly (because, that would make more sense), that they sign-off on the new header? |
Does «All rights reserved» mean anything nowdays in any country? Wikipedia says:
|
Largely just an artifact of history, I believe. I don't have a problem removing it |
@jasnell I have a highly subjective opinion that it makes it a bit more aggresive for no good reason, e.g. I wouldn't be very surprised if someone who doesn't know what exactly that means would be scared off by it instead of reusing code and/or contributing. Just ignore me if no one else thinks that way, though =). This concern is both subjective and very minor. |
Removing the "All rights reserved" I think would be fine. I can update the proposal accordingly. |
I'm not too sure about |
From legal committee, preferred language:
The legal committee consensus is that this should not be landed yet but that the simplified text with the SPDX reference should be used. The legal committee also wanted to note that the "All rights reserved" should remain because it is used in other vendored notice blocks and it might cause confusion if it were in some files but not others. |
I will get the PRs updated by Tuesday or Wednesday of next week.
I will also be introducing lint rules to ensure that the appropriate copyright statements appear at the top of each file |
ea2f036
to
19dbeb4
Compare
This PR has been updated to only include the new proposed license header and an eslint rule to enforce it's use. @bnoordhuis @jbergstroem ... we need a similar rule for cpplint to check the src/.h and src/.cc files. I'm not that familiar with cpplint so perhaps either of you could help? |
Shouldn't be too hard. Remove |
ok, so just make the change directly to the cpplint.py script. That's what I suspected but needed to be sure. Thank you! |
19dbeb4
to
578100d
Compare
A prior io.js era commit inappropriately removed the original copyright statements from the source. This restores those in any files still remaining from that edit. Ref: nodejs/TSC#174 Ref: nodejs#10599
A prior io.js era commit inappropriately removed the original copyright statements from the source. This restores those in any files still remaining from that edit. Ref: nodejs/TSC#174 Ref: #10599 PR-URL: #10155 Note: This PR was required, reviewed-by and approved by the Node.js Foundation Legal Committee and the TSC. There is no `Approved-By:` meta data.
A prior io.js era commit inappropriately removed the original copyright statements from the source. This restores those in any files still remaining from that edit. Ref: nodejs/TSC#174 Ref: nodejs#10599 PR-URL: nodejs#10155 Note: This PR was required, reviewed-by and approved by the Node.js Foundation Legal Committee and the TSC. There is no `Approved-By:` meta data.
Closing this due to any lack of progress. |
This is a WIP follow-on to #10155
It updates the copyright notices in the lib/src files. This is WIP and must not be landed until @nodejs/tsc signoff and Node.js Foundation Legal Committee review.
/cc @mikeal
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
lib, src