test: refactor beforeExit tests #10581
Conversation
Trott
added
process
|
There are only 43 tests with mixed/ I don't think mixed case is conventional, and I don't think its a good idea. Some file systems aren't case-sensitive, and in the test names that do have |
|
Yeah let's leave it lowercase. |
| })); | ||
| } | ||
|
|
There was a problem hiding this comment.
I wonder why nextTick is not tested here.
| })); | ||
| } | ||
|
|
||
| const N = 5; | ||
| let n = 0; |
There was a problem hiding this comment.
Can these be closed over or something? If we add more tests later, having top level variables would make them inconvenient I guess.
|
There are two dimensions of the tests: one is to test the various mechanisms to ensure they are dealt with (tick/timeout/net listen/etc.), the other is to test recursive use of a single mechanism. There are lots of ways to refactor this, and there are dimensions not covered by the tests (not everything is done recursively), but in the absence of regressions, I don't know if anyone has the energy to write them all. |
|
Actually after a second look I wonder if these shouldn't just be kept separate? |
|
@sam-github Renamed the file so it is without mixed case. PTAL |
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate.
|
@thefourtheye Block-scoped the |
|
Only failure in CI is Jenkins/Hudson related. But this test ran and succeeded before the failure, so CI is effectively ✅ |
|
Landed in d2c96af |
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate. PR-URL: #10581 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
retroactive LGTM, @Trott , sorry, still digging out of my email |
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate. PR-URL: nodejs#10581 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate. PR-URL: nodejs#10581 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate. PR-URL: #10581 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate. PR-URL: nodejs#10581 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate. PR-URL: nodejs#10581 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Combine and rename tests for the
beforeExitevent onprocess.The naming now more closely follows the de facto conventions of the
project.
The two tests were very similar and do not seem to benefit from being
separate.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test process