Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: accept empty net.Sockets #1046

Closed
wants to merge 1 commit into from
Closed

tls: accept empty net.Sockets #1046

wants to merge 1 commit into from

Commits on Mar 3, 2015

  1. tls: accept empty net.Sockets 

    Accept `new net.Socket()` as a `socket` option to `tls.connect()`
without triggering an assertion error in C++.

This is done by wrapping it into a JSStream to ensure that there will be
a handle at the time of wrapping the socket into TLSSocket.

Fix: nodejs#987
    @indutny
    indutny committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    e471150 View commit details
    Browse the repository at this point in the history