test: improve the code in test-pipe.js #10452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
mscdex
reviewed
Dec 25, 2016
|
|
||
| req.pipe(socket); | ||
|
|
||
| req.on('end', function() { | ||
| req.on('end', common.mustCall(() => { | ||
| res.writeHead(200); | ||
| res.write('thanks'); | ||
| res.end(); | ||
| console.log('response with \'thanks\''); |
There was a problem hiding this comment.
Can we remove these log statements too? Also the process.stdout.write() statements.
mscdex
reviewed
Dec 25, 2016
|
|
||
| req.connection.on('error', function(e) { | ||
| req.connection.on('error', (e) => { | ||
| assert.ifError(e); | ||
| console.log('http server-side error: ' + e.message); | ||
| process.exit(1); |
There was a problem hiding this comment.
I think this can be removed now that we're asserting.
mscdex
added
http
|
@mscdex, changed as suggested |
jasnell
approved these changes
Dec 26, 2016
|
LGTM |
lpinca
reviewed
Dec 26, 2016
| res.setEncoding('utf8'); | ||
| res.on('data', function(string) { | ||
| assert.equal('thanks', string); | ||
| res.on('data', (string) => { |
There was a problem hiding this comment.
Nit: how about wrapping this listener with common.mustCall and remove the gotThanks flag?
There was a problem hiding this comment.
@lpinca the problem adding the common.mustCall for this event, is that we are not sure about the exact number of times this function will be called, every time the test run the number could be different, so adding it will make the test to fail sporadically
There was a problem hiding this comment.
@edsadr there is an assertion which basically check that the listener is called once.
assert.strictEqual('thanks', string);If the are multiple chunks then the assertion fails anyway.
lpinca
approved these changes
Dec 26, 2016
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write
|
@lpinca , I stand corrected I was checking the other event: s.on('data', (d) => {
tcpLengthSeen += d.length;
for (let j = 0; j < d.length; j++) {
assert.strictEqual(buffer[i], d[j]);
i++;
}
});That one is the one being called multiple times, just fixed the one you suggested and I guess just left to set the CI |
|
Landed fc103bb |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Description of change