Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-stdin-from-file #10331

Closed
wants to merge 1 commit into from
Closed

test: refactor test-stdin-from-file #10331

wants to merge 1 commit into from

Conversation

radelmann
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Remove console.log() statement.
  • Replace error check with assert.ifError().

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 19, 2016
@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Dec 19, 2016
@radelmann
test: refactor test-stdin-from-file
f34f8c1 
Remove console.log statement. Replace error check with assert.ifError().
@radelmann
Copy link
Contributor Author

bump

@jasnell
Copy link
Member

jasnell commented Dec 23, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5559/

@jasnell jasnell self-assigned this Dec 23, 2016
@italoacasas
Copy link
Contributor

@jasnell are u going to land this ?

@jasnell
Copy link
Member

jasnell commented Dec 29, 2016

Yeah, have just been catching up on things.. appreciate the ping!

jasnell pushed a commit that referenced this pull request Dec 29, 2016
@radelmann @jasnell
test: refactor test-stdin-from-file
407c1ad 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 29, 2016

Landed in 407c1ad

@jasnell jasnell closed this Dec 29, 2016
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@radelmann @evanlucas
test: refactor test-stdin-from-file
fa29bb2 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@radelmann @evanlucas
test: refactor test-stdin-from-file
04d82a5 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@radelmann @MylesBorins
test: refactor test-stdin-from-file
678e983 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@radelmann @MylesBorins
test: refactor test-stdin-from-file
e197129 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@radelmann @MylesBorins
test: refactor test-stdin-from-file
a2309e6 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@radelmann @MylesBorins
test: refactor test-stdin-from-file
bff21b4 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@radelmann @MylesBorins
test: refactor test-stdin-from-file
99c9cda 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@radelmann @MylesBorins
test: refactor test-stdin-from-file
14e07c9 
Remove console.log statement. Replace error check with
assert.ifError().

PR-URL: #10331
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@jasnell jasnell

Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@radelmann @jasnell @italoacasas @lpinca @cjihrig @mscdex @MylesBorins @nodejs-github-bot