-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 4.0.5 #10330
deps: upgrade npm to 4.0.5 #10330
Conversation
CI: https://ci.nodejs.org/job/node-test-commit/6719/ I’m +1 on pulling this into Node 7. |
@addaleax Remember, the regular CI does not significantly test npm. |
I'll merge this to |
Discussed briefly on the CTC call today but we did not have quorum to make any actual decisions. There were no objections to getting this landed in master or v7. @nodejs/ctc ... if anyone has objections please raise them here as soon as possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests pass locally LGTM
landed in 9946519 |
PR-URL: #10330 Reviewed-By: Myles Borins <[email protected]>
Should this be marked semver-minor? |
@evanlucas Yea, I think that makes sense here |
PR-URL: #10330 Reviewed-By: Myles Borins <[email protected]>
Notable changes: * buffer: - Improve performance of Buffer allocation by ~11% (Brian White) #10443 - Improve performance of Buffer.from() by ~50% (Brian White) #10443 * events: Improve performance of EventEmitter.once() by ~27% (Brian White) #10445 * fs: Allow passing Uint8Array to fs methods where Buffers are supported. (Anna Henningsen) #10382 * http: Improve performance of http server by ~7% (Brian White) #6533 * npm: Upgrade to v4.0.5 (Kat Marchán) #10330 PR-URL: #10589
Notable changes: * buffer: - Improve performance of Buffer allocation by ~11% (Brian White) #10443 - Improve performance of Buffer.from() by ~50% (Brian White) #10443 * events: Improve performance of EventEmitter.once() by ~27% (Brian White) #10445 * fs: Allow passing Uint8Array to fs methods where Buffers are supported. (Anna Henningsen) #10382 * http: Improve performance of http server by ~7% (Brian White) #6533 * npm: Upgrade to v4.0.5 (Kat Marchán) #10330 PR-URL: #10589
This comment was marked as abuse.
This comment was marked as abuse.
Can you cover the shrinkwrap change a bit more? The two notes state:
The lines that are throwing me are:
Followed by:
Are devDepenencies included but somehow treated less complete than direct dependencies? |
@jdalton I'm gonna ping @iarna on this to check this cause I may be confused (and this stuff is changing again soon), but lmk if this helps clarify things:
|
It does. Thank you! |
Notable changes: * buffer: - Improve performance of Buffer allocation by ~11% (Brian White) nodejs/node#10443 - Improve performance of Buffer.from() by ~50% (Brian White) nodejs/node#10443 * events: Improve performance of EventEmitter.once() by ~27% (Brian White) nodejs/node#10445 * fs: Allow passing Uint8Array to fs methods where Buffers are supported. (Anna Henningsen) nodejs/node#10382 * http: Improve performance of http server by ~7% (Brian White) nodejs/node#6533 * npm: Upgrade to v4.0.5 (Kat Marchán) nodejs/node#10330 PR-URL: nodejs/node#10589 Signed-off-by: Ilkka Myller <[email protected]>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
deps
Description of change
Breaking Changes
npm search
rewritten to stream results, and no longer supports sorting.npm scripts
no longer prepend the path of the node executable used to run npm before running scripts. A--scripts-prepend-node-path
option has been added to configure this behavior. (/cc @addaleax)prepublish
has been deprecated, replaced byprepare
. AprepublishOnly
script has been temporarily added, which will only run onnpm publish
. NOTE: This change only affects users publishing new versions of their packages and developers installing through git and local deps. Registry installs should be (mostly) unaffected by this change.npm outdated
exits with exit code1
if it finds any outdated packages. (/cc @watilde)npm tag
has been removed after a deprecation cycle. Usenpm dist-tag
.npm-shrinkwrap.json
is considered a complete installation manifest except fordevDependencies
. This will affect certain projects that relied heavily on this feature, most notablyhapi
.devDependencies
are now included innpm-shrinkwrap.json
by default. This should make the transition tonpm@5
easier.Other Notable Changes
Npm-In-CI
andNpm-Scope
headers to registries when fetching modules. The former will allow registries to more accurately distinguish between CI and user traffic. The latter will allow registries to implement features on the basis of the scope of the project (rather than the module actually being installed).d8471a2
npm/npm#12811 Fixes issue wherenpm install
needed to be run twice whendevDependencies
had conflicting subdeps withdependencies
. (@schmod)Changelogs
v4.0.0
v4.0.1
v4.0.2
v4.0.3
v4.0.5
r: @Fishrock123
r: @addaleax
r: @jasnell