doc: some fixes in repl.md #10244

vsemozhetbyt · 2016-12-13T00:00:17Z

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc, repl

Description of change

var => let / const.
White space unification (add an infix space in an argument list; change > into > (with a trailing space) in code bits and output examples; explicitly clarify that default REPL prompt contains a trailing space).
Fix an output example (make _ reassignment example match with the current output; extend the example for more clarity).
Fix a function name (eval => myEval to not shadow the global eval).
Replace anonymous functions with an object shorthand and an arrow function.
Add the valid link for curl(1) (The current autoinserted link leads to 404 page).

I am sorry I've messed up the previous PR by an inexperienced rebasing during resolving a conflict. Excuse me for wasting your time.

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space.

Make `_` reassignment example match more with the current output. Extend the example for more clarity.

`eval` => `myEval` to not shadow the global `eval`

Replaced with an object shorthand and an arrow function.

vsemozhetbyt · 2016-12-14T22:27:42Z

/cc @nodejs/documentation

vsemozhetbyt · 2016-12-16T16:26:10Z

@addaleax, @eljefedelrodeodeljefe, @lance, you had reviewed the previous ill-fated PR. If anybody has the time, could you please look at this? Sorry for the disturbing.

addaleax

LGTM with a grammar nit

addaleax · 2016-12-17T01:15:29Z

doc/api/repl.md

-declared either implicitly or using the `var` keyword are declared at the
-`global` scope.
+Unless otherwise scoped within blocks or functions, variables declared
+either implicitly, or using the `const`, `let`, or `var` keywords


The , here doesn’t seem quite right to me?

@addaleax Do you mean "let, or var"? It is a @lance's sentence. It seems he uses Oxford comma here. Should I change it to "let or var"?

Or do you mean another comma?

Oh, sorry. I mean the one after implicitly… the Oxford comma after let seems okay here :)

Amended with the last commit. Thank you :)

The current autoinserted link leads to 404 page.

thefourtheye · 2016-12-20T23:14:03Z

cc @princejwesley

vsemozhetbyt · 2016-12-25T15:08:22Z

@addaleax, @jasnell, @thefourtheye Could this be landed?

PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Make `_` reassignment example match more with the current output. Extend the example for more clarity. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

`eval` => `myEval` to not shadow the global `eval` PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replaced with an object shorthand and an arrow function. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

The current autoinserted link leads to 404 page. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

addaleax · 2016-12-25T18:52:25Z

@vsemozhetbyt Thanks for the ping!

Landed in 45c9ca7...f501178.

PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Make `_` reassignment example match more with the current output. Extend the example for more clarity. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

`eval` => `myEval` to not shadow the global `eval` PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replaced with an object shorthand and an arrow function. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

The current autoinserted link leads to 404 page. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Make `_` reassignment example match more with the current output. Extend the example for more clarity. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

`eval` => `myEval` to not shadow the global `eval` PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replaced with an object shorthand and an arrow function. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

The current autoinserted link leads to 404 page. PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins · 2017-01-23T00:46:49Z

Would someone be willing to manually backport these changes to v6.x?

vsemozhetbyt added 5 commits December 13, 2016 01:28

doc: var => let / const in repl.md

61f4eab

doc: white space unification in repl.md

94ff2e1

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space.

doc: fix an output example in repl.md

38b4cb4

Make `_` reassignment example match more with the current output. Extend the example for more clarity.

doc: fix a function name in repl.md

36ba6b8

`eval` => `myEval` to not shadow the global `eval`

doc: replace anonymous functions in repl.md

0eb327d

Replaced with an object shorthand and an arrow function.

nodejs-github-bot added dont-land-on-v7.x doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Dec 13, 2016

vsemozhetbyt changed the title ~~Repl.md~~ doc: some fixes in repl.md Dec 13, 2016

italoacasas removed the dont-land-on-v7.x label Dec 13, 2016

addaleax approved these changes Dec 17, 2016

View reviewed changes

doc: add the valid link for curl(1) in repl.md

ceee0d8

The current autoinserted link leads to 404 page.

nodejs-github-bot added the dont-land-on-v7.x label Dec 17, 2016

addaleax approved these changes Dec 17, 2016

View reviewed changes

italoacasas removed the dont-land-on-v7.x label Dec 18, 2016

thefourtheye approved these changes Dec 20, 2016

View reviewed changes

jasnell approved these changes Dec 22, 2016

View reviewed changes

addaleax pushed a commit that referenced this pull request Dec 25, 2016

doc: var => let / const in repl.md

c919dd7

PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

addaleax closed this Dec 25, 2016

vsemozhetbyt deleted the repl.md branch December 25, 2016 18:55

evanlucas mentioned this pull request Jan 3, 2017

v7.4.0 release proposal #10589

Merged

evanlucas pushed a commit that referenced this pull request Jan 3, 2017

doc: var => let / const in repl.md

60ac904

PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

evanlucas pushed a commit that referenced this pull request Jan 4, 2017

doc: var => let / const in repl.md

37cb971

PR-URL: #10244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins added dont-land-on-v4.x labels Jan 23, 2017

MylesBorins added the backport-requested-v6.x label May 8, 2017

vsemozhetbyt mentioned this pull request Dec 12, 2017

doc: autogenerated links with 404 status #17637

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: some fixes in repl.md #10244

doc: some fixes in repl.md #10244

vsemozhetbyt commented Dec 13, 2016 •

edited

Loading

vsemozhetbyt commented Dec 14, 2016

vsemozhetbyt commented Dec 16, 2016

addaleax left a comment

addaleax Dec 17, 2016

vsemozhetbyt Dec 17, 2016 •

edited

Loading

addaleax Dec 17, 2016

vsemozhetbyt Dec 17, 2016

thefourtheye commented Dec 20, 2016

vsemozhetbyt commented Dec 25, 2016 •

edited

Loading

addaleax commented Dec 25, 2016

MylesBorins commented Jan 23, 2017

doc: some fixes in repl.md #10244

doc: some fixes in repl.md #10244

Conversation

vsemozhetbyt commented Dec 13, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

vsemozhetbyt commented Dec 14, 2016

vsemozhetbyt commented Dec 16, 2016

addaleax left a comment

Choose a reason for hiding this comment

addaleax Dec 17, 2016

Choose a reason for hiding this comment

vsemozhetbyt Dec 17, 2016 • edited Loading

Choose a reason for hiding this comment

addaleax Dec 17, 2016

Choose a reason for hiding this comment

vsemozhetbyt Dec 17, 2016

Choose a reason for hiding this comment

thefourtheye commented Dec 20, 2016

vsemozhetbyt commented Dec 25, 2016 • edited Loading

addaleax commented Dec 25, 2016

MylesBorins commented Jan 23, 2017

vsemozhetbyt commented Dec 13, 2016 •

edited

Loading

vsemozhetbyt Dec 17, 2016 •

edited

Loading

vsemozhetbyt commented Dec 25, 2016 •

edited

Loading