Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify the review and landing process #10202

Closed
wants to merge 10 commits into from
Closed

doc: clarify the review and landing process #10202

wants to merge 10 commits into from

Commits on Dec 11, 2016

  1. doc: clarify the review and landing process 

    - Explains what "nits" stand for
- Explains commit squashing
- Mentions the CI run
- Mentions the mandatory 48/72 hours wait
- Mention GitHub's PR review feature
- Fix indentation
    @joyeecheung
    joyeecheung committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    cc22d35 View commit details
    Browse the repository at this point in the history

  2. doc: clarify the landing process 

    - Mention the "landed in <sha>" comment when a PR gets landed
    @joyeecheung
    joyeecheung committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    e8153b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2016

  1. doc: explain the waiting time of semver-major PRs

    @joyeecheung
    joyeecheung committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    0bb76ba View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2016

  1. doc: put the notes and details in the back

    @joyeecheung
    joyeecheung committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    32ab27a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2016

  1. doc: improve the clarification

    @joyeecheung
    joyeecheung committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    9bda4a4 View commit details
    Browse the repository at this point in the history

  2. doc: more fixes about the process

    @joyeecheung
    joyeecheung committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    dbd83ef View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2016

  1. doc: amends the contributing guide

    @joyeecheung
    joyeecheung committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    96e0189 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2016

  1. doc: testing docs, PR history preservation

    @joyeecheung
    joyeecheung committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    246f52a View commit details
    Browse the repository at this point in the history

  2. doc: fix typo

    @joyeecheung
    joyeecheung committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    e9c53f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2016

  1. doc: trim trailling spaces

    @joyeecheung
    joyeecheung committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    41e4e93 View commit details
    Browse the repository at this point in the history