test: add test for process.stdin.setRawMode() #10037

jmdarling · 2016-12-01T17:53:37Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

Description of change

adds a basic test for process.stdin.setRawMode to ensure that the isRaw
property is properly changed

adds a basic test for process.stdin.setRawMode to ensure that the isRaw property is properly changed

bnoordhuis

LGTM with a suggestion.

bnoordhuis · 2016-12-01T21:00:17Z

test/pseudo-tty/stdin-setrawmode.js

+assert(process.stdin.isRaw);
+
+process.stdin.setRawMode(false);
+assert(!process.stdin.isRaw);


Perhaps you can use assert.strictEqual instead of plain assert, that would catch truthy-but-not-boolean values.

Replaces usages of plain assert() with assert.strictEqual() to prevent issues with "truthiness" or "falsiness".

bnoordhuis

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/5075/ (currently queued)

adds a basic test for process.stdin.setRawMode to ensure that the isRaw property is properly changed PR-URL: #10037 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

jasnell · 2016-12-05T22:25:38Z

Landed in 3ae0900. Thank you for the PR and for participating in the code-and-learn!

Fishrock123 · 2016-12-06T14:57:13Z

This test doesn't exactly function correctly:

Could not find /Users/Jeremiah/Documents/node/test/pseudo-tty/stdin-setrawmode.out

You need an .out file too for pseudo-tty tests, I'm not sure if the test is actually run or not in this situation.

We should probably update the message and pseudo-tty test runners to error without an .out file, I am not familiar enough with python to do that in any speedy manner though.

jmdarling · 2016-12-06T16:18:53Z

Well that's no good. My apologies. When I ran the test individually and with the test suite on my local I didn't see any problems, but obviously I didn't look closely enough. Now that I'm looking more closely I see the same thing you're seeing.

Unfortunately, I am quite uninformed on how these pseuty-tty tests work, and am not seeing any documentation. Am I just missing it?

Judging by the other tests in that directory, since I am not writing anything to stdout, can I just create an empty .out file (just a single newline)? Doing this seems to get rid of that error but I'm not sure if it will cause other issues.

addaleax · 2016-12-06T16:19:39Z

Judging by the other tests in that directory, since I am not writing anything to stdout, can I just create an empty .out file (just a single newline)?

Yeah that should be fine

Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at nodejs#10037.

jmdarling · 2016-12-06T16:27:47Z

I have opened a PR to add the .out file: #10146

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: nodejs#10037

adds a basic test for process.stdin.setRawMode to ensure that the isRaw property is properly changed PR-URL: #10037 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) => { console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at #10037. PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

adds a basic test for process.stdin.setRawMode to ensure that the isRaw property is properly changed PR-URL: #10037 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at #10037. PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) => { console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at #10037. PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) => { console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at #10037. PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) => { console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at #10037. PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

test: add test for process.stdin.setRawMode()

28f858a

adds a basic test for process.stdin.setRawMode to ensure that the isRaw property is properly changed

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016

imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016

bnoordhuis approved these changes Dec 1, 2016

View reviewed changes

test: replace assert with assert.strictEqual

f788228

Replaces usages of plain assert() with assert.strictEqual() to prevent issues with "truthiness" or "falsiness".

bnoordhuis approved these changes Dec 1, 2016

View reviewed changes

cjihrig approved these changes Dec 1, 2016

View reviewed changes

addaleax approved these changes Dec 2, 2016

View reviewed changes

mscdex added the tty Issues and PRs related to the tty subsystem. label Dec 3, 2016

jasnell approved these changes Dec 5, 2016

View reviewed changes

jasnell closed this Dec 5, 2016

jmdarling mentioned this pull request Dec 6, 2016

test: add stdin-setrawmode.out file to accompany test #10146

Closed

3 tasks

Fishrock123 mentioned this pull request Dec 6, 2016

doc: add some info on tty#setRawMode() #10147

Merged

2 tasks

addaleax mentioned this pull request Dec 6, 2016

test: set stdin too for pseudo-tty tests #10149

Closed

2 tasks

addaleax added a commit to addaleax/node that referenced this pull request Dec 6, 2016

test: fail for missing output files

39336cf

Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: nodejs#10037

addaleax mentioned this pull request Dec 6, 2016

test: fail for missing output files #10150

Closed

2 tasks

Fishrock123 added lts-watch-v4.x labels Dec 9, 2016

MylesBorins mentioned this pull request Dec 21, 2016

V6.9.3 proposal #10394

Merged

targos removed the lts-watch-v6.x label Dec 26, 2016

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Jan 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add test for process.stdin.setRawMode() #10037

test: add test for process.stdin.setRawMode() #10037

jmdarling commented Dec 1, 2016

bnoordhuis left a comment

bnoordhuis Dec 1, 2016

bnoordhuis left a comment

jasnell commented Dec 5, 2016

Fishrock123 commented Dec 6, 2016 •

edited

Loading

jmdarling commented Dec 6, 2016

addaleax commented Dec 6, 2016

jmdarling commented Dec 6, 2016

test: add test for process.stdin.setRawMode() #10037

test: add test for process.stdin.setRawMode() #10037

Conversation

jmdarling commented Dec 1, 2016

Checklist

Affected core subsystem(s)

Description of change

bnoordhuis left a comment

Choose a reason for hiding this comment

bnoordhuis Dec 1, 2016

Choose a reason for hiding this comment

bnoordhuis left a comment

Choose a reason for hiding this comment

jasnell commented Dec 5, 2016

Fishrock123 commented Dec 6, 2016 • edited Loading

jmdarling commented Dec 6, 2016

addaleax commented Dec 6, 2016

jmdarling commented Dec 6, 2016

Fishrock123 commented Dec 6, 2016 •

edited

Loading